Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate other members UserName and DisplayName in E2EI [WPB-10402] 🍒 🍒 #2943

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2024

BugWPB-10402 [Android] Validate Other Members Username and DisplayName in E2EI Identity

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:


What's new in this PR?

Issues

The checking "if user has valid E2EI" was not full in Participants list and UserProfile.
We should also check if users displayName and handle are the same as in E2EI certificate.

Causes (Optional)

Was not implemented.

Solutions

Implement it and add/update tests for new scenarios.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. type: bug / fix 🐞 👕 size: M 🚨 Potential breaking changes labels Aug 9, 2024
Copy link

sonarqubecloud bot commented Aug 9, 2024

Copy link
Contributor Author

github-actions bot commented Aug 9, 2024

Test Results

3 154 tests  +4   3 049 ✔️ +4   3m 32s ⏱️ -8s
   540 suites ±0      105 💤 ±0 
   540 files   ±0          0 ±0 

Results for commit e6326bf. ± Comparison against base commit be8472c.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

github-actions bot commented Aug 9, 2024

🐰Bencher

ReportFri, August 9, 2024 at 13:34:31 UTC
Projectkalium
Branchfix/validate_other_members_username_and_displayname_in_e2ei-cherry-pick-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)688,008.84
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)377,817,549.73
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)930,545,743.61
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,261,314.20

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 43.18182% with 25 lines in your changes missing coverage. Please review.

Project coverage is 52.47%. Comparing base (be8472c) to head (e6326bf).

Files Patch % Lines
.../logic/data/conversation/ConversationRepository.kt 0.00% 6 Missing ⚠️
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% 5 Missing ⚠️
...secase/GetMembersE2EICertificateStatusesUseCase.kt 71.42% 0 Missing and 4 partials ⚠️
...om/wire/kalium/persistence/dao/member/MemberDAO.kt 0.00% 4 Missing ⚠️
.../com/wire/kalium/logic/data/user/UserRepository.kt 0.00% 3 Missing ⚠️
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2943      +/-   ##
===========================================
- Coverage    52.51%   52.47%   -0.05%     
===========================================
  Files         1289     1290       +1     
  Lines        49528    49580      +52     
  Branches      4600     4604       +4     
===========================================
+ Hits         26012    26018       +6     
- Misses       21674    21717      +43     
- Partials      1842     1845       +3     
Files Coverage Δ
.../e2ei/usecase/FetchMLSVerificationStatusUseCase.kt 88.00% <100.00%> (ø)
...ture/e2ei/usecase/GetUserE2EICertificateUseCase.kt 100.00% <100.00%> (ø)
.../kotlin/com/wire/kalium/persistence/dao/UserDAO.kt 96.29% <ø> (ø)
.../com/wire/kalium/logic/data/user/UserRepository.kt 67.69% <0.00%> (-0.64%) ⬇️
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 52.66% <0.00%> (-0.54%) ⬇️
...secase/GetMembersE2EICertificateStatusesUseCase.kt 76.47% <71.42%> (-14.44%) ⬇️
...om/wire/kalium/persistence/dao/member/MemberDAO.kt 71.02% <0.00%> (-2.76%) ⬇️
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% <0.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt 62.32% <0.00%> (-0.78%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8472c...e6326bf. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/validate_other_members_username_and_displayname_in_e2ei-cherry-pick-cherry-pick
Commit report: e4ca240
Test service: kalium-jvm

✅ 0 Failed, 3049 Passed, 105 Skipped, 11.9s Total Time

@borichellow borichellow added this pull request to the merge queue Aug 9, 2024
Merged via the queue into develop with commit f755a71 Aug 9, 2024
22 checks passed
@borichellow borichellow deleted the fix/validate_other_members_username_and_displayname_in_e2ei-cherry-pick-cherry-pick branch August 9, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants