Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignoreDisabledTargets when building with CI that does not support apple targets #2944

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

removing unwanted gradle logs about not supported targets

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title ciL: ignoreDisabledTargets when building with CI that does not support apple targets ci: ignoreDisabledTargets when building with CI that does not support apple targets Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Test Results

3 164 tests  ±0   3 059 ✔️ ±0   3m 24s ⏱️ -28s
   541 suites ±0      105 💤 ±0 
   541 files   ±0          0 ±0 

Results for commit 3f99d7c. ± Comparison against base commit 20e5b85.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 12, 2024

Datadog Report

Branch report: ci/fix-fdroid-build
Commit report: 2204ba1
Test service: kalium-jvm

✅ 0 Failed, 3059 Passed, 105 Skipped, 10.14s Total Time

Signed-off-by: MohamadJaara <[email protected]>
@MohamadJaara MohamadJaara enabled auto-merge August 12, 2024 20:49
Copy link

@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 12, 2024
Merged via the queue into release/candidate with commit 738f6c3 Aug 12, 2024
21 of 22 checks passed
@MohamadJaara MohamadJaara deleted the ci/fix-fdroid-build branch August 12, 2024 21:39
github-actions bot pushed a commit that referenced this pull request Aug 12, 2024
… apple targets (#2944)

* ciL: ignoreDisabledTargets when building with CI that does not support apple targets

* Trigger CI

Signed-off-by: MohamadJaara <[email protected]>

---------

Signed-off-by: MohamadJaara <[email protected]>
MohamadJaara added a commit that referenced this pull request Aug 13, 2024
… apple targets (#2944)

* ciL: ignoreDisabledTargets when building with CI that does not support apple targets

* Trigger CI

Signed-off-by: MohamadJaara <[email protected]>

---------

Signed-off-by: MohamadJaara <[email protected]>
(cherry picked from commit 738f6c3)
MohamadJaara added a commit that referenced this pull request Sep 2, 2024
… apple targets (#2944) (#2945)

* ciL: ignoreDisabledTargets when building with CI that does not support apple targets

* Trigger CI



---------

Signed-off-by: MohamadJaara <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants