fix: Check file extension instead of mimeType [WPB-10605] #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
alexandreferris,
MohamadJaara,
vitorhugods,
ohassine and
saleniuk
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
| @@ -133,7 +133,7 @@ internal class ScheduleNewAssetMessageUseCaseImpl( | |||
| FileSharingStatus.Value.EnabledAll -> { /* no-op*/ | |||
| } | |||
|
|
|||
| is FileSharingStatus.Value.EnabledSome -> if (!validateAssetMimeTypeUseCase(assetMimeType, it.state.allowedType)) { | |||
| is FileSharingStatus.Value.EnabledSome -> if (!validateAssetMimeTypeUseCase(assetName, it.state.allowedType)) { | |||
There was a problem hiding this comment.
can we change the name of the user case to reflect what it does now
yamilmedina
reviewed
Aug 15, 2024
| * Returns true if the mime type is allowed and false otherwise. | ||
| * @param mimeType the mime type to validate. | ||
| * Returns true if the file extension is present in file name and is allowed and false otherwise. | ||
| * @param fileName the file name (with extension) to validate. | ||
| * @param allowedExtension the list of allowed extension. | ||
| */ | ||
| interface ValidateAssetMimeTypeUseCase { |
There was a problem hiding this comment.
Suggested change
| interface ValidateAssetMimeTypeUseCase { | |
| interface ValidateAssetFileTypeUseCase { |
| val extension = mimeType.split("/").last().lowercase() | ||
| return allowedExtension.any { | ||
| it.lowercase() == extension | ||
| override operator fun invoke(fileName: String, allowedExtension: List<String>): Boolean { |
There was a problem hiding this comment.
Question: What if we have multiple extensions hiding in the file or other type of tricks ? Would be good idea to follow some of these tips ?
https://book.hacktricks.xyz/pentesting-web/file-upload#bypass-file-extensions-checks
| @@ -53,7 +53,7 @@ internal class AssetMessageHandlerImpl( | |||
| FileSharingStatus.Value.EnabledAll -> true | |||
|
|
|||
| is FileSharingStatus.Value.EnabledSome -> validateAssetMimeTypeUseCase( | |||
| messageContent.value.mimeType, | |||
| messageContent.value.name ?: "", | |||
There was a problem hiding this comment.
to avoid any hidden bugs we can pass the name as nullable string and handle the null case by returning not valid
|
yamilmedina
approved these changes
Aug 15, 2024
MohamadJaara
approved these changes
Aug 16, 2024
This was referenced Aug 16, 2024
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
in
ValidateAssetMimeTypeUseCasewhen we calculate if file can be shared or not we were comparing files mimeType to list of allowed Extensions.Causes (Optional)
Just was implemented in that way long time ago.
Solutions
fix it and compare files extension to list of allowed Extensions.