-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent cancellation midway through event processing [WPB-7070] #2952
Merged
MohamadJaara
merged 2 commits into
release/candidate
from
fix/prevent-missing-messages-on-flaky-internet
Aug 16, 2024
Merged
fix: prevent cancellation midway through event processing [WPB-7070] #2952
MohamadJaara
merged 2 commits into
release/candidate
from
fix/prevent-missing-messages-on-flaky-internet
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorhugods
requested review from
MohamadJaara,
a team,
alexandreferris,
Garzas,
ohassine and
saleniuk
and removed request for
a team
August 15, 2024 12:49
echoes-hq
bot
added
the
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
label
Aug 15, 2024
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
Aug 15, 2024
Quality Gate passedIssues Measures |
Datadog ReportBranch report: ✅ 0 Failed, 3066 Passed, 105 Skipped, 10.3s Total Time |
alexandreferris
approved these changes
Aug 15, 2024
MohamadJaara
approved these changes
Aug 15, 2024
borichellow
approved these changes
Aug 16, 2024
MohamadJaara
approved these changes
Aug 16, 2024
MohamadJaara
deleted the
fix/prevent-missing-messages-on-flaky-internet
branch
August 16, 2024 10:30
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
) Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
🚨 Potential breaking changes
👕 size: M
type: bug / fix 🐞
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
It's possible to have event processing being cancelled midway through and we would still mark them as processed.
Causes
Although unlikely, if we cancel the event processing midway through due to connectivity changing or websocket closing, we may swallow cancellation exceptions in
wrapStorageRequest
, and we do not return success/failure to the EventProcessor itself, as it expects exceptions to be thrown.Solutions
The idea is to completely forbid cancellation midway through event processing, by:
withContext(NonCancellable) {}
Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.