-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missed call message does not get marked as read if self user called (WPB-10208) #2953
fix: Missed call message does not get marked as read if self user called (WPB-10208) #2953
Conversation
Quality Gate passedIssues Measures |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2953 +/- ##
===========================================
+ Coverage 52.47% 52.54% +0.06%
===========================================
Files 1290 1291 +1
Lines 49580 49594 +14
Branches 4604 4605 +1
===========================================
+ Hits 26018 26058 +40
+ Misses 21717 21667 -50
- Partials 1845 1869 +24
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3054 Passed, 105 Skipped, 13.6s Total Time |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Missed call message does not get marked as read if self user called
Causes (Optional)
We are updating
ConversationReadDate
if the message is coming from selfUserSolutions
Exclude missedCall type so
ConversationReadDate
will be updated if the message is coming from self user and not a missed call.Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.