Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missed call message does not get marked as read if self user called (WPB-10208) #2953

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 15, 2024

BugWPB-10208 [Android] Missed call message does not get marked as read if self user called


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Missed call message does not get marked as read if self user called

Causes (Optional)

We are updating ConversationReadDate if the message is coming from selfUser

Solutions

Exclude missedCall type so ConversationReadDate will be updated if the message is coming from self user and not a missed call.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 15, 2024
Copy link

@ohassine ohassine requested review from a team, typfel, alexandreferris, mchenani, Garzas and saleniuk and removed request for a team August 15, 2024 15:27
Copy link
Contributor

github-actions bot commented Aug 15, 2024

Test Results

3 159 tests  +4   3 054 ✔️ +4   3m 36s ⏱️ +25s
   542 suites +1      105 💤 ±0 
   542 files   +1          0 ±0 

Results for commit 3ce970a. ± Comparison against base commit ad1bbe2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰Bencher

ReportThu, August 15, 2024 at 15:38:26 UTC
Projectkalium
BranchMissed-call-message-does-not-get-marked-as-read-if-self-user-called
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)679,951.97
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)444,295,130.27
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)932,284,906.07
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,442,642.97

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.54%. Comparing base (f755a71) to head (3ce970a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2953      +/-   ##
===========================================
+ Coverage    52.47%   52.54%   +0.06%     
===========================================
  Files         1290     1291       +1     
  Lines        49580    49594      +14     
  Branches      4604     4605       +1     
===========================================
+ Hits         26018    26058      +40     
+ Misses       21717    21667      -50     
- Partials      1845     1869      +24     
Files Coverage Δ
...kalium/logic/data/message/PersistMessageUseCase.kt 21.53% <100.00%> (+21.53%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f755a71...3ce970a. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: Missed-call-message-does-not-get-marked-as-read-if-self-user-called
Commit report: b346651
Test service: kalium-jvm

✅ 0 Failed, 3054 Passed, 105 Skipped, 13.6s Total Time

@ohassine ohassine added this pull request to the merge queue Aug 16, 2024
Merged via the queue into develop with commit 147eb18 Aug 16, 2024
23 checks passed
@ohassine ohassine deleted the Missed-call-message-does-not-get-marked-as-read-if-self-user-called branch August 16, 2024 15:14
ohassine added a commit that referenced this pull request Aug 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants