Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup MLSCallHelper class (WPB-7153) - cherrypick RC #2957

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 16, 2024

StoryWPB-7153 [Android] Add flag for customer specific 1:1 calls in federated environment


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cherrypick of #2938

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 16, 2024
@ohassine ohassine requested review from a team, typfel, alexandreferris, mchenani, Garzas and saleniuk and removed request for a team August 16, 2024 15:33
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Test Results

3 179 tests  ±0   3 074 ✔️ ±0   3m 8s ⏱️ -14s
   544 suites ±0      105 💤 ±0 
   544 files   ±0          0 ±0 

Results for commit 6db39d1. ± Comparison against base commit 683661d.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 16, 2024

Datadog Report

Branch report: cleanup-MLSCallHelper-class-rc
Commit report: e32d002
Test service: kalium-jvm

✅ 0 Failed, 3074 Passed, 105 Skipped, 9.93s Total Time

Copy link

@ohassine ohassine added this pull request to the merge queue Aug 19, 2024
Merged via the queue into release/candidate with commit ec81cb6 Aug 19, 2024
22 checks passed
@ohassine ohassine deleted the cleanup-MLSCallHelper-class-rc branch August 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants