Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Testservice can create new MLS conversations (WPB-9185) #2993

Closed
wants to merge 4 commits into from

Conversation

mythsunwind
Copy link
Collaborator

@mythsunwind mythsunwind commented Sep 4, 2024

TaskWPB-9185 Testservice can create MLS conversations


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR adds a new endpoint to create MLS conversations since conversations with MLS need a client that initialize them (in contract to proteus conversations which can be created by the backend).

Example:
PUT /conversation { name: 'My new conversation', users: ['234324-2343243-34324234@domain']}

@mythsunwind mythsunwind requested review from a team, yamilmedina, MohamadJaara, vitorhugods, mchenani and Garzas and removed request for a team September 4, 2024 12:16
Copy link

sonarqubecloud bot commented Sep 4, 2024

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Test Results

0 tests   - 3 197   0 ✔️  - 3 092   0s ⏱️ - 3m 40s
0 suites  -    550   0 💤  -    105 
0 files    -    550   0 ±       0 

Results for commit 59df99c. ± Comparison against base commit 59ddcf2.

♻️ This comment has been updated with latest results.

@mythsunwind mythsunwind closed this Sep 4, 2024
@mythsunwind mythsunwind deleted the feat/testservice-new-conversation branch September 4, 2024 12:26
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🐰Bencher

ReportWed, September 4, 2024 at 12:32:44 UTC
Projectkalium
Branchfeat/testservice-new-conversation
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)686,387.66
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)403,689,311.62
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)923,733,923.98
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,458,347.09

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.60%. Comparing base (27532f3) to head (59df99c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2993   +/-   ##
========================================
  Coverage    52.60%   52.60%           
========================================
  Files         1296     1296           
  Lines        49823    49823           
  Branches      4648     4648           
========================================
  Hits         26207    26207           
  Misses       21739    21739           
  Partials      1877     1877           

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27532f3...59df99c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants