Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle the case where asset name can be missing [WPB-10830] #2995

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
detekt
  • Loading branch information
MohamadJaara committed Sep 6, 2024
commit 7bfce71f88bc695175703008abac17981ab7e032
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,10 @@ internal class AssetMessageHandlerImpl(
FileSharingStatus.Value.EnabledAll -> true

is FileSharingStatus.Value.EnabledSome -> {
// If the asset message is missing the name, but it does have full asset data then we can not decide now if it is allowed or not
// it is safe to continue and the code later will check the original asset message and decide if it is allowed or not
// If the asset message is missing the name, but it does have full
// asset data then we can not decide now if it is allowed or not
// it is safe to continue and the code later will check the original
// asset message and decide if it is allowed or not
if (message.content.value.name.isNullOrEmpty() && message.content.value.isCompleteAssetData) {
kaliumLogger.e("The asset message trying to be processed has invalid data looking locally")
true
Expand Down