Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove call to deleteSubConversation after ending 1:1 call (WPB-11007) #3000

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 9, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

We need to remove the call to DELETE /conversations/:domain/:uuid/subconversations/conference and revert the call to leaveMlsConference after ending a 1:1 call on SFT.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 9, 2024
@ohassine ohassine requested review from a team, typfel, yamilmedina, alexandreferris, borichellow and MohamadJaara and removed request for a team September 9, 2024 16:23
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Test Results

2 926 tests   2 803 ✔️  22s ⏱️
   497 suites     123 💤
   497 files           0

Results for commit 31cbd6a.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 9, 2024

Datadog Report

All test runs 0d96325 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2802 123 1.26s Link
kalium-jvm 0 0 0 2953 107 5.09s Link

@ohassine ohassine enabled auto-merge (squash) September 16, 2024 08:50
Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/android-cycle-4.6@9eafc77). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             release/android-cycle-4.6    #3000   +/-   ##
============================================================
  Coverage                             ?   58.54%           
  Complexity                           ?        7           
============================================================
  Files                                ?     1188           
  Lines                                ?    46921           
  Branches                             ?     4470           
============================================================
  Hits                                 ?    27471           
  Misses                               ?    17457           
  Partials                             ?     1993           
Files with missing lines Coverage Δ
.../kalium/logic/feature/call/scenario/OnCloseCall.kt 81.57% <100.00%> (ø)
...tlin/com/wire/kalium/logic/data/call/CallHelper.kt 55.55% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eafc77...31cbd6a. Read the comment docs.

@ohassine ohassine merged commit 8728f13 into release/android-cycle-4.6 Sep 16, 2024
19 checks passed
@ohassine ohassine deleted the Remove-call-to-deleteSubConversation-after-ending- branch September 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants