-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove call to deleteSubConversation after ending 1:1 call (WPB-11007) #3000
chore: Remove call to deleteSubConversation after ending 1:1 call (WPB-11007) #3000
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
…bConversation-after-ending-
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/android-cycle-4.6 #3000 +/- ##
============================================================
Coverage ? 58.54%
Complexity ? 7
============================================================
Files ? 1188
Lines ? 46921
Branches ? 4470
============================================================
Hits ? 27471
Misses ? 17457
Partials ? 1993
Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Description
We need to remove the call to DELETE /conversations/:domain/:uuid/subconversations/conference and revert the call to leaveMlsConference after ending a 1:1 call on SFT.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.