fix: incorrect sender & receiver ID on generated events [WPB-11075]

[typfel]

WPB-11075 Add debug tool for importing events from an external file

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

1. The sender and receiver IDs shouldn't be qualified on the conversation.new-otr-message event.
2. The same ID was set for both sender and receiver

The IOS client discards event because of this.

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 197 tests  ±0   3 092 ✔️ ±0   3m 43s ⏱️ +12s
   550 suites ±0      105 💤 ±0 
   550 files   ±0          0 ❌ ±0 

Results for commit 29632eb. ± Comparison against base commit 7f991e6.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher

Report	Fri, September 13, 2024 at 09:15:44 UTC
Project	kalium
Branch	fix/sender-receiver-id
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	➖ (view plot)	695,663.95
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	➖ (view plot)	602,117,795.31
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	➖ (view plot)	923,655,525.13
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	➖ (view plot)	21,763,751.27

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (7f991e6) to head (29632eb).

Files with missing lines	Patch %	Lines
...com/wire/kalium/logic/data/event/EventGenerator.kt	0.00%	12 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3005      +/-   ##
===========================================
- Coverage    52.52%   52.51%   -0.02%     
===========================================
  Files         1299     1299              
  Lines        49953    49958       +5     
  Branches      4655     4655              
===========================================
- Hits         26238    26233       -5     
- Misses       21835    21845      +10     
  Partials      1880     1880              

Files with missing lines	Coverage Δ
...com/wire/kalium/logic/data/event/EventGenerator.kt	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f991e6...29632eb. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/sender-receiver-id
Commit report: 95a049e
Test service: kalium-jvm

✅ 0 Failed, 3092 Passed, 105 Skipped, 11.64s Total Time

[MohamadJaara]

lgtm, only formatting nitpick

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud