fix(proteus): prevent missing messages by using transactions [WPB-10873] 🍒

[github-actions]

WPB-10873 Version 4.8 does not deliver all attachments in a group chat

This PR was automatically cherry-picked based on the following PR:

• fix(proteus): prevent missing messages by using transactions [WPB-10873] #2992

Original PR description:

---

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Some clients reported missing messages.
We found that it is not that hard to kill the app by swiping it away between decryption and DB insertion.

Solutions

• CoreCrypto doesn't support transactions yet: every decrypt persist state and if the app dies after decrypting, the message is forever gone.
• CryptoBox does to some degree. It doesn't support rolling back a transaction gracefully. It requires recreating a CoreCrypto instance using the same files. So we can at least simulate app killing by recreating this.

By not saving the session before inserting the messages into the DB, we can try to process this event again and recover this message.

Changed the API so instead of returning ByteArray, the Proteus clients will accept a lambda to process the output.
After allowing processing the output, the Proteus clients will persist the session.
CoreCrypto (that doesn't support saving session later) will decrypt and call the lambda normally.

Testing

Test Coverage

• I have added automated test to this contribution

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[yamilmedina]

:(

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Test Results

3 206 tests  +2   3 099 ✔️ ±0   4m 1s ⏱️ +33s
   551 suites ±0      107 💤 +2 
   551 files   ±0          0 ❌ ±0 

Results for commit e617029. ± Comparison against base commit 582e546.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 68.11594% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.55%. Comparing base (582e546) to head (e617029).

Files with missing lines	Patch %	Lines
...ver/conversation/message/ProteusMessageUnpacker.kt	40.62%	19 Missing ⚠️
...kalium/cryptography/ProteusClientCoreCryptoImpl.kt	71.42%	2 Missing ⚠️
...ver/conversation/message/NewMessageEventHandler.kt	96.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3007   +/-   ##
========================================
  Coverage    52.54%   52.55%           
========================================
  Files         1301     1301           
  Lines        50059    50066    +7     
  Branches      4666     4665    -1     
========================================
+ Hits         26304    26310    +6     
- Misses       21880    21883    +3     
+ Partials      1875     1873    -2     

Files with missing lines	Coverage Δ
...tlin/com/wire/kalium/cryptography/ProteusClient.kt	87.50% <ø> (ø)
...ver/conversation/message/NewMessageEventHandler.kt	83.49% <96.66%> (+1.94%)	⬆️
...kalium/cryptography/ProteusClientCoreCryptoImpl.kt	44.66% <71.42%> (+0.54%)	⬆️
...ver/conversation/message/ProteusMessageUnpacker.kt	60.93% <40.62%> (-4.58%)	⬇️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582e546...e617029. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/proteus/use-transactions-for-cryptobox-cherry-pick
Commit report: c691be4
Test service: kalium-jvm

✅ 0 Failed, 3099 Passed, 107 Skipped, 12.27s Total Time