Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: observe only current call [WPB-3959] #3011

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 13, 2024

SpikeWPB-3959 Android - Some avatars are default(not visible) in a group call


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added callerId to CallMetadata to not unnecessary execute db queries for current established call
  • improved callerId parsing (it was parsed twice in some scenarios)
  • introduced ObserveEstablishedCallWithSortedParticipantsUseCase to only listen for current call and to not sort participants on every call

@Garzas Garzas self-assigned this Sep 13, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 13, 2024
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Test Results

3 198 tests  +1   3 093 ✔️ +1   3m 43s ⏱️ +12s
   550 suites ±0      105 💤 ±0 
   550 files   ±0          0 ±0 

Results for commit 0052aab. ± Comparison against base commit 7f991e6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 13, 2024

🐰Bencher

ReportFri, September 13, 2024 at 15:21:11 UTC
Projectkalium
Branchchore/observe-current-call
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)685,751.25
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)324,782,642.29
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)919,795,361.97
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,751,921.74

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (7f991e6) to head (0052aab).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rveEstablishedCallWithSortedParticipantsUseCase.kt 0.00% 7 Missing ⚠️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% 4 Missing ⚠️
.../com/wire/kalium/logic/data/call/CallRepository.kt 60.00% 2 Missing ⚠️
...ain/kotlin/com/wire/kalium/logic/data/call/Call.kt 0.00% 1 Missing ⚠️
...wire/kalium/logic/data/call/CallMetadataProfile.kt 0.00% 1 Missing ⚠️
...lium/logic/feature/call/scenario/OnIncomingCall.kt 0.00% 1 Missing ⚠️
...m/wire/kalium/logic/data/call/mapper/CallMapper.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3011      +/-   ##
===========================================
- Coverage    52.52%   52.49%   -0.03%     
===========================================
  Files         1299     1300       +1     
  Lines        49953    49967      +14     
  Branches      4655     4656       +1     
===========================================
- Hits         26238    26232       -6     
- Misses       21835    21853      +18     
- Partials      1880     1882       +2     
Files with missing lines Coverage Δ
...ain/kotlin/com/wire/kalium/logic/data/call/Call.kt 0.00% <0.00%> (ø)
...wire/kalium/logic/data/call/CallMetadataProfile.kt 0.00% <0.00%> (ø)
...lium/logic/feature/call/scenario/OnIncomingCall.kt 0.00% <0.00%> (ø)
...m/wire/kalium/logic/data/call/mapper/CallMapper.kt 72.50% <0.00%> (-0.84%) ⬇️
.../com/wire/kalium/logic/data/call/CallRepository.kt 87.06% <60.00%> (-0.48%) ⬇️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% <0.00%> (ø)
...rveEstablishedCallWithSortedParticipantsUseCase.kt 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f991e6...0052aab. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 13, 2024

Datadog Report

Branch report: chore/observe-current-call
Commit report: 4305e85
Test service: kalium-jvm

✅ 0 Failed, 3093 Passed, 105 Skipped, 12.84s Total Time

Copy link

@Garzas Garzas added this pull request to the merge queue Sep 16, 2024
Merged via the queue into develop with commit c9ca072 Sep 16, 2024
22 checks passed
@Garzas Garzas deleted the chore/observe-current-call branch September 16, 2024 08:33
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
* chore: observe only current call

* kotlin update

* downgrade compose compiler and kotlin

* version typo

* tests fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: M type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants