fix: random decryption errors after ending 1:1 on SFT (WPB-11213) #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
requested review from
a team,
borichellow,
vitorhugods,
mchenani,
Garzas and
mathias-niboulies
and removed request for
a team
|
| @@ -32,6 +32,7 @@ actual fun mapMLSException(exception: Exception): MLSFailure = | |||
| is CryptoError.StaleCommit -> MLSFailure.StaleCommit | |||
| is CryptoError.ConversationAlreadyExists -> MLSFailure.ConversationAlreadyExists | |||
| is CryptoError.MessageEpochTooOld -> MLSFailure.MessageEpochTooOld | |||
| is CryptoError.MlsException -> MLSFailure.InternalErrors | |||
There was a problem hiding this comment.
question: should we do this to all internal errors, or only when it is related to sub conversation messages
There was a problem hiding this comment.
I think so, we can make it for this specific case only, but it's error prone as we will base on string
MohamadJaara
requested review from
MohamadJaara
and removed request for
mathias-niboulies
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
MohamadJaara
approved these changes
Sep 24, 2024
yamilmedina
approved these changes
Sep 24, 2024
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
…#3039) * fix: Ignore MLSException (#3022) (#3025) Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]> * chore: empty commit --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Some random decryption errors after ending 1:1 on SFT.
Causes (Optional)
A race condition when we try to delete or decrypt a message related to the call and the sub conversation.
Solutions
Ignore MlsException to not show the decryption
(iOS and web already ignoring it)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.