Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when login after session expire and client deleted remotely [WPB-11061] #3031

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

crash when login after session expire and client deleted remotely

Solutions

reset a flag to fetch E2EI trust anchor when logout

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  1. login to env with e2ei and MLS enabled with client A
  2. logout from client A
  3. form a second client delete client A
  4. open client A and login again
  5. finish setup cert
  6. no KaBoom! app works

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title Fix/login after session expire fix: crash when login after session expire and client deleted remotely Sep 25, 2024
@MohamadJaara MohamadJaara changed the title fix: crash when login after session expire and client deleted remotely fix: crash when login after session expire and client deleted remotely [WPB-11061] Sep 25, 2024
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Test Results

3 071 tests   2 964 ✔️  3m 37s ⏱️
   524 suites     107 💤
   524 files           0

Results for commit 4466e93.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 25, 2024

Datadog Report

All test runs 8ed7c4f 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 645 92 591ms Link
kalium-jvm 0 0 0 706 42 4s Link

Copy link

@MohamadJaara MohamadJaara enabled auto-merge (squash) September 25, 2024 10:04
@MohamadJaara MohamadJaara merged commit bea029d into release/android-cycle-4.6 Sep 25, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the fix/login-after-session-expire branch September 25, 2024 10:21
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants