Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use latest version of bencher as required per cloud flavor (WPB-8645) #3036

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Sep 25, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

PRs failing with errors for bencher not up to date

Causes (Optional)

Cloud flavor, requires to us to use latest CLI version

Solutions

Use latest instead of fixed versions.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

@yamilmedina yamilmedina changed the title chore: use latest version of bencher as required per cloud flavor (WPB-8645) ci: use latest version of bencher as required per cloud flavor (WPB-8645) Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Test Results

3 202 tests  ±0   3 095 ✅ ±0   3m 24s ⏱️ -29s
  551 suites ±0     107 💤 ±0 
  551 files   ±0       0 ❌ ±0 

Results for commit fd86fef. ± Comparison against base commit 3d4468b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchchore/fix-version-bench
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
701,396.23
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
692,512,579.13
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
949,226,086.97
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,673,204.73
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.52%. Comparing base (3d4468b) to head (fd86fef).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3036      +/-   ##
===========================================
- Coverage    52.52%   52.52%   -0.01%     
===========================================
  Files         1301     1301              
  Lines        50043    50043              
  Branches      4663     4663              
===========================================
- Hits         26286    26285       -1     
- Misses       21884    21885       +1     
  Partials      1873     1873              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4468b...fd86fef. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/fix-version-bench
Commit report: 0538155
Test service: kalium-jvm

✅ 0 Failed, 3095 Passed, 107 Skipped, 10.59s Total Time

@yamilmedina yamilmedina added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit 597cdec Sep 25, 2024
26 checks passed
@yamilmedina yamilmedina deleted the chore/fix-version-bench branch September 25, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants