-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mls): set removal-keys for 1on1 calls from conversation-response (WPB-10743) π π #3041
fix(mls): set removal-keys for 1on1 calls from conversation-response (WPB-10743) π π #3041
Conversation
β¦ederated-1on1-removal-keys-cherry-pick-cherry-pick
Quality Gate passedIssues Measures |
Test Results3β212 testsβ +2βββ3β106 β
+2βββ4m 0s β±οΈ -8s Results for commit c5b3f2c.βΒ± Comparison against base commit 27fc353. β»οΈ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3041 +/- ##
===========================================
- Coverage 52.56% 52.51% -0.06%
===========================================
Files 1303 1303
Lines 50104 50174 +70
Branches 4671 4679 +8
===========================================
+ Hits 26338 26349 +11
- Misses 21884 21939 +55
- Partials 1882 1886 +4
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: β 0 Failed, 3106 Passed, 106 Skipped, 12.37s Total Time |
β¦(WPB-10743) π π (#3041) * Commit with unresolved merge conflicts * fix merge conflicts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohamad Jaara <[email protected]>
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Fetch and set removal-keys from the create-conversation response for 1on1 conversations and only APIV6
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.