chore: optional calling [WPB-9999]

[Garzas]

WPB-9999 [Android] Investigate the text message event handling bottleneck and spickes

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Sometimes calling library doesn't load for tango tests.

Causes (Optional)

Flaky tango tests

Solutions

Make calling manager optional by kalium config to disable it for tests

How to Test

run givenEmailAndPasswordWhenLoggingInThenRegisterClientAndLogout test

[github-actions]

Test Results

3 208 tests  ±0   3 102 ✅ +1   3m 51s ⏱️ -3s
  551 suites ±0     106 💤  - 1 
  551 files   ±0       0 ❌ ±0 

Results for commit 4525dda. ± Comparison against base commit 025b3f7.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	chore/nullable-calling-instance
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	701,663.65
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	626,584,863.15
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	936,752,115.03
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,516,452.34

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (025b3f7) to head (4525dda).

Files with missing lines	Patch %	Lines
...lin/com/wire/kalium/logic/util/DummyCallManager.kt	0.00%	17 Missing ⚠️
...mAndroid/kotlin/com.wire.kalium.calling/Calling.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3043      +/-   ##
===========================================
- Coverage    52.52%   52.50%   -0.02%     
===========================================
  Files         1301     1302       +1     
  Lines        50044    50062      +18     
  Branches      4663     4663              
===========================================
+ Hits         26284    26285       +1     
- Misses       21883    21900      +17     
  Partials      1877     1877              

Files with missing lines	Coverage Δ
...om/wire/kalium/logic/featureFlags/KaliumConfigs.kt	100.00% <100.00%> (ø)
...mAndroid/kotlin/com.wire.kalium.calling/Calling.kt	0.00% <0.00%> (ø)
...lin/com/wire/kalium/logic/util/DummyCallManager.kt	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025b3f7...4525dda. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: chore/nullable-calling-instance
Commit report: 176371c
Test service: kalium-jvm

✅ 0 Failed, 3102 Passed, 106 Skipped, 11.28s Total Time

[vitorhugods]

What is the goal exactly? Disabling calling for tango tests?

It definitely isn't solving the issue, but rather accepting the issue exists and making the production code less null-safe in the process.

---

If the idea is to accept that calling won't work in tango tests, we could just disable it completely.

When creating CoreLogic, we could pass a Calling.Disabled or something like that, that will do NO-OPs in every calling operation without breaking anything nor sacrifice the CallManagerImpl.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud