Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mock websocket session [WPB-9999] #3046

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Sep 30, 2024

SpikeWPB-9999 [Android] Investigate the text message event handling bottleneck and spickes


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Added mock web socket session option to kalium config needed in tango tests.
In future this should be more customizable to have more control of web socket events in tango tests

@Garzas Garzas self-assigned this Sep 30, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Test Results

3 209 tests  ±0   3 102 ✅ ±0   3m 50s ⏱️ -4s
  551 suites ±0     107 💤 ±0 
  551 files   ±0       0 ❌ ±0 

Results for commit b5d3f75. ± Comparison against base commit 21bbf39.

♻️ This comment has been updated with latest results.

Copy link

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 30, 2024

Datadog Report

Branch report: chore/mock-websocket-session
Commit report: 78c9d1c
Test service: kalium-jvm

✅ 0 Failed, 3102 Passed, 107 Skipped, 13s Total Time

@Garzas Garzas requested a review from yamilmedina September 30, 2024 08:25
Copy link
Contributor

🐰 Bencher Report

Branchchore/mock-websocket-session
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
703,082.82
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
405,400,708.30
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
932,161,130.35
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,459,891.77
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 11.11111% with 56 lines in your changes missing coverage. Please review.

Project coverage is 52.58%. Comparing base (21bbf39) to head (b5d3f75).

Files with missing lines Patch % Lines
.../networkContainer/AuthenticatedNetworkContainer.kt 17.64% 14 Missing ⚠️
.../wire/kalium/network/utils/MockWebSocketSession.kt 0.00% 11 Missing ⚠️
.../network/api/v0/authenticated/NotificationApiV0.kt 0.00% 5 Missing ⚠️
...in/kotlin/com/wire/kalium/network/NetworkClient.kt 20.00% 4 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV2.kt 0.00% 4 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV3.kt 0.00% 4 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV4.kt 0.00% 4 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV5.kt 0.00% 4 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV6.kt 0.00% 4 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV0.kt 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3046      +/-   ##
===========================================
- Coverage    52.61%   52.58%   -0.04%     
===========================================
  Files         1301     1302       +1     
  Lines        50044    50086      +42     
  Branches      4663     4671       +8     
===========================================
+ Hits         26333    26338       +5     
- Misses       21831    21867      +36     
- Partials      1880     1881       +1     
Files with missing lines Coverage Δ
...om/wire/kalium/logic/featureFlags/KaliumConfigs.kt 100.00% <100.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV0.kt 22.85% <50.00%> (+0.98%) ⬆️
...in/kotlin/com/wire/kalium/network/NetworkClient.kt 68.18% <20.00%> (-5.16%) ⬇️
...etworkContainer/AuthenticatedNetworkContainerV2.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV3.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV4.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV5.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV6.kt 0.00% <0.00%> (ø)
.../network/api/v0/authenticated/NotificationApiV0.kt 52.38% <0.00%> (+2.38%) ⬆️
.../wire/kalium/network/utils/MockWebSocketSession.kt 0.00% <0.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bbf39...b5d3f75. Read the comment docs.

@Garzas Garzas enabled auto-merge September 30, 2024 09:41
@Garzas Garzas added this pull request to the merge queue Sep 30, 2024
Merged via the queue into develop with commit d22a888 Sep 30, 2024
22 checks passed
@Garzas Garzas deleted the chore/mock-websocket-session branch September 30, 2024 10:12
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
* chore: mock-websocket-session

* tests fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. 🚨 Potential breaking changes 👕 size: M type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants