Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Legalhold implementation in testservice (WPB-10479) #3047

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

mythsunwind
Copy link
Collaborator

@mythsunwind mythsunwind commented Sep 30, 2024

BugWPB-10479 Migrate last two remaining test cases using ETS instead of kalium testservice


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The endpoint /sendText was missing an attribute to set the legalhold status.

Solutions

Add status attribute and run approve tasks if it is set to true.

@mythsunwind mythsunwind requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and saleniuk and removed request for a team September 30, 2024 11:30
Copy link

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Test Results

3 209 tests  ±0   3 103 ✅ ±0   4m 32s ⏱️ +47s
  551 suites ±0     106 💤 ±0 
  551 files   ±0       0 ❌ ±0 

Results for commit 69fd362. ± Comparison against base commit d22a888.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchtestservice-legalhold
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
707,410.91
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
342,370,487.31
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
940,714,247.85
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,389,646.13
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.56%. Comparing base (d22a888) to head (69fd362).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3047   +/-   ##
========================================
  Coverage    52.56%   52.56%           
========================================
  Files         1303     1303           
  Lines        50104    50104           
  Branches      4671     4671           
========================================
  Hits         26338    26338           
  Misses       21885    21885           
  Partials      1881     1881           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22a888...69fd362. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: testservice-legalhold
Commit report: 20203a1
Test service: kalium-jvm

✅ 0 Failed, 3103 Passed, 106 Skipped, 17.18s Total Time

@mythsunwind mythsunwind added this pull request to the merge queue Oct 1, 2024
Merged via the queue into develop with commit 4687ee8 Oct 1, 2024
22 checks passed
@mythsunwind mythsunwind deleted the testservice-legalhold branch October 1, 2024 08:12
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
* fix: Testservice automatically approves legal hold requests (WPB-8746)

* legalHoldStatus 2 is enabled (1 is disabled)

* Only check legalHoldStatus if it is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants