-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conversation list pagination, pt2 - pager and use case [WPB-9433] #3058
Conversation
…ist-pagination-pt1-queries' into feat/conversation-list-pagination-pt2-pagers
Test Results2 808 tests - 411 2 800 ✅ - 313 4m 24s ⏱️ +42s Results for commit 4fd92b4. ± Comparison against base commit fc3f3e3. This pull request removes 3219 and adds 2808 tests. Note that renamed tests count towards both.
This pull request removes 106 skipped tests and adds 8 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1 Passed, 0 Skipped, 0s Total Time |
Bencher Report
Click to view all benchmark results
|
…conversation-list-pagination-pt2-pagers # Conflicts: # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/conversation/ConversationDAOImpl.kt
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3058 +/- ##
===========================================
+ Coverage 52.24% 52.45% +0.21%
===========================================
Files 1314 1316 +2
Lines 50951 51020 +69
Branches 4724 4729 +5
===========================================
+ Hits 26617 26762 +145
+ Misses 22439 22337 -102
- Partials 1895 1921 +26
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
This PR implements all required paging extensions and a new use case to make use of new queries and sql views added in #3055 and to make it possible to paginate conversation lists, archived ones, search for conversations, filter only conversations that allow for interaction with user (the ones where user is allowed to send messages) and return in specific order required for different screens (new activities grouped on top or not).
Dependencies (Optional)
This PR needs to be merged first (it contains first part of required changes):
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.