Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conversation list pagination, pt2 - pager and use case [WPB-9433] #3059

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Oct 14, 2024

StoryWPB-9433 [Android] Implement Pagination for Conversation Screen Data Retrieval


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR implements all required paging extensions and a new use case to make use of new queries and sql views added in #3055 and to make it possible to paginate conversation lists, archived ones, search for conversations, filter only conversations that allow for interaction with user (the ones where user is allowed to send messages) and return in specific order required for different screens (new activities grouped on top or not).

Dependencies (Optional)

This PR needs to be merged first (it contains first part of required changes):

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…ist-pagination-pt1-queries' into feat/conversation-list-pagination-pt2-pagers
…conversation-list-pagination-pt2-pagers

# Conflicts:
#	persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/conversation/ConversationDAOImpl.kt
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

Test Results

3 243 tests  +8   3 137 ✅ +8   4m 8s ⏱️ +9s
  554 suites +2     106 💤 ±0 
  554 files   +2       0 ❌ ±0 

Results for commit 23e2bd4. ± Comparison against base commit cf44646.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

🐰 Bencher Report

Branchfeat/conversation-list-pagination-pt2-pagers
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
694,245.31
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
403,748,728.57
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
930,809,235.51
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,495,348.20
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 14, 2024

Datadog Report

Branch report: feat/conversation-list-pagination-pt2-pagers
Commit report: 98f3528
Test service: kalium-jvm

✅ 0 Failed, 3137 Passed, 106 Skipped, 16.47s Total Time

Copy link

@saleniuk saleniuk requested review from a team, m-zagorski, alexandreferris, borichellow, MohamadJaara and Garzas and removed request for a team October 14, 2024 15:20
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.57143% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.44%. Comparing base (cf44646) to head (23e2bd4).

Files with missing lines Patch % Lines
...a/conversation/ConversationRepositoryExtensions.kt 46.66% 16 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 3 Missing ⚠️
.../logic/data/conversation/ConversationRepository.kt 50.00% 1 Missing ⚠️
...ersistence/dao/conversation/ConversationDAOImpl.kt 50.00% 1 Missing ⚠️
...istence/dao/conversation/ConversationExtensions.kt 96.96% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3059      +/-   ##
===========================================
+ Coverage    52.24%   52.44%   +0.20%     
===========================================
  Files         1314     1316       +2     
  Lines        50951    51020      +69     
  Branches      4724     4729       +5     
===========================================
+ Hits         26617    26758     +141     
+ Misses       22439    22341      -98     
- Partials      1895     1921      +26     
Files with missing lines Coverage Δ
...um/persistence/dao/conversation/ConversationDAO.kt 100.00% <ø> (ø)
.../logic/data/conversation/ConversationRepository.kt 62.03% <50.00%> (-0.06%) ⬇️
...ersistence/dao/conversation/ConversationDAOImpl.kt 72.79% <50.00%> (-0.17%) ⬇️
...istence/dao/conversation/ConversationExtensions.kt 96.96% <96.96%> (ø)
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...a/conversation/ConversationRepositoryExtensions.kt 46.66% <46.66%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf44646...23e2bd4. Read the comment docs.

@saleniuk saleniuk added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit 5e31dec Oct 15, 2024
22 checks passed
@saleniuk saleniuk deleted the feat/conversation-list-pagination-pt2-pagers branch October 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. 🚨 Potential breaking changes 👕 size: XL type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants