fix: secure message draft saving [WPB-11325]

[Garzas]

WPB-11325 [Android] Can not open conversations

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

There were situations when saving message draft cause error in db android.database.sqlite.SQLiteConstraintException: FOREIGN KEY constraint failed (code 787)

Causes (Optional)

Not working conversations when there was some saved draft

Solutions

Secure draft saving with checks needed to save a draft

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

1. Start typing message in conversation with some reply or editting message
2. Remove on web message only for you which you are editing or replying to
3. continue typing on android
4. there should not be any issues with db on logs

[github-actions]

Test Results

3 238 tests  +3   3 132 ✅ +3   4m 16s ⏱️ +17s
  552 suites ±0     106 💤 ±0 
  552 files   ±0       0 ❌ ±0 

Results for commit d29aa58. ± Comparison against base commit cf44646.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (cf44646) to head (d29aa58).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3061      +/-   ##
===========================================
+ Coverage    52.24%   52.51%   +0.27%     
===========================================
  Files         1314     1314              
  Lines        50951    51013      +62     
  Branches      4724     4734      +10     
===========================================
+ Hits         26617    26788     +171     
+ Misses       22439    22327     -112     
- Partials      1895     1898       +3     

Files with missing lines	Coverage Δ
...rsistence/dao/message/draft/MessageDraftDAOImpl.kt	83.33% <100.00%> (+13.33%)	⬆️
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt	80.64% <100.00%> (+0.25%)	⬆️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf44646...d29aa58. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/save-message-draft
Commit report: fb3a981
Test service: kalium-jvm

✅ 0 Failed, 3132 Passed, 106 Skipped, 16.99s Total Time

[github-actions]

Bencher Report

Branch	fix/save-message-draft
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	680,692.80
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	602,356,255.54
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	927,527,595.46
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,590,099.54

🐰 View full continuous benchmarking report in Bencher

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud