-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show sync retry state for internal build #WPB-11198 #3062
Conversation
|
Branch | feat/show-sync-retry-state |
Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
CLI flag.
Click to view all benchmark results
Benchmark | Latency | nanoseconds (ns) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 681,861.40 |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 325,099,328.62 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 936,088,983.15 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,554,526.42 |
Datadog ReportBranch report: ✅ 0 Failed, 3144 Passed, 106 Skipped, 30.22s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3062 +/- ##
===========================================
- Coverage 52.70% 52.70% -0.01%
===========================================
Files 1317 1317
Lines 51108 51112 +4
Branches 4742 4742
===========================================
+ Hits 26936 26937 +1
- Misses 22247 22249 +2
- Partials 1925 1926 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
What's new in this PR?
Issues
Add more debug info in top bar when sync is waiting for the network. This is only available on internal builds.
Solutions
Dependencies (Optional)
Needs releases with:
Testing
How to Test
Disconnect from internet and run the app
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.