Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: android gradle plugin update [WPB-983] #3064

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 16, 2024

StoryWPB-983 Snapshot tests for UI changes verification


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated android gradle plugin needed for screenshot tests

Copy link

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Test Results

3 250 tests  ±0   3 144 ✅ ±0   3m 40s ⏱️ -35s
  555 suites ±0     106 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 6a5e0ea. ± Comparison against base commit 0bc15da.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.70%. Comparing base (0bc15da) to head (6a5e0ea).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3064      +/-   ##
=====================================================
- Coverage              52.70%   52.70%   -0.01%     
=====================================================
  Files                   1317     1317              
  Lines                  51108    51108              
  Branches                4742     4742              
=====================================================
- Hits                   26936    26935       -1     
  Misses                 22247    22247              
- Partials                1925     1926       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc15da...6a5e0ea. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/agp-8-5
Commit report: a251e25
Test service: kalium-jvm

✅ 0 Failed, 3144 Passed, 106 Skipped, 25.94s Total Time

@Garzas Garzas added this pull request to the merge queue Oct 17, 2024
Merged via the queue into release/candidate with commit 35cfb92 Oct 17, 2024
21 checks passed
@Garzas Garzas deleted the chore/agp-8-5 branch October 17, 2024 06:50
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
* chore: android gradle plugin update (#3064)

* Empty-Commit

---------

Co-authored-by: Jakub Żerko <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2024
* chore: android gradle plugin update (#3064)

* chore: update sqlcipher [WPB-11808] (#3069)

(cherry picked from commit 2ddb183)

* feat: add a wild card request

* return response as string

* detekt package name

---------

Co-authored-by: Jakub Żerko <[email protected]>
Co-authored-by: Michał Saleniuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants