Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wild card http request builder [WPB-11845] #3075

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Oct 24, 2024

StoryWPB-11845 [Android] create wild card api call for debugging


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

sometimes you need a quick and durty way to do an authenticated request to wire backend

Solutions

add a wild card request where path, body, parameters and headrs can be customised and kalium takes care of the rest (host name, api version aand auth tokens)

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara force-pushed the feat/add-wild-card-http-request-builder branch from 2a0d04d to bd85a23 Compare October 24, 2024 11:57
Copy link

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Test Results

3 250 tests  ±0   3 144 ✅ ±0   4m 35s ⏱️ +8s
  555 suites ±0     106 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit bd85a23. ± Comparison against base commit 2ddb183.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchfeat/add-wild-card-http-request-builder
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
664,532.58
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
601,722,942.71
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
930,843,682.61
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,971,346.98
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.68%. Comparing base (2ddb183) to head (bd85a23).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...wire/kalium/network/api/vcommon/WildCardApiImpl.kt 0.00% 16 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV0.kt 0.00% 1 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV2.kt 0.00% 1 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV3.kt 0.00% 1 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV4.kt 0.00% 1 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV5.kt 0.00% 1 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV6.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3075      +/-   ##
===========================================
- Coverage    52.70%   52.68%   -0.03%     
===========================================
  Files         1317     1318       +1     
  Lines        51112    51134      +22     
  Branches      4742     4743       +1     
===========================================
- Hits         26941    26939       -2     
- Misses       22246    22270      +24     
  Partials      1925     1925              
Files with missing lines Coverage Δ
.../networkContainer/AuthenticatedNetworkContainer.kt 26.31% <ø> (ø)
...etworkContainer/AuthenticatedNetworkContainerV0.kt 22.22% <0.00%> (-0.64%) ⬇️
...etworkContainer/AuthenticatedNetworkContainerV2.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV3.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV4.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV5.kt 0.00% <0.00%> (ø)
...etworkContainer/AuthenticatedNetworkContainerV6.kt 0.00% <0.00%> (ø)
...wire/kalium/network/api/vcommon/WildCardApiImpl.kt 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddb183...bd85a23. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/add-wild-card-http-request-builder
Commit report: 8a9f777
Test service: kalium-jvm

✅ 0 Failed, 3144 Passed, 106 Skipped, 36.76s Total Time

@MohamadJaara MohamadJaara changed the title feat: add wild card http request builder feat: add wild card http request builder [WPB-11845] Oct 25, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Oct 25, 2024
Merged via the queue into develop with commit 71aef39 Oct 25, 2024
24 of 25 checks passed
@MohamadJaara MohamadJaara deleted the feat/add-wild-card-http-request-builder branch October 25, 2024 09:16
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants