feat: Consider team settings when registering mls device #WPB-10119

[m-zagorski]

WPB-10119 [Android] Clients should initialize MLS clients according to backend feature flag

https://wearezeta.atlassian.net/browse/WPB-10119

What's new in this PR?

Issues

We now need to check team settings before registering a mls client

Solutions

Add another check before mls device registration

Testing

How to Test

Make sure registering device only when: feature flag is on, mls keys are present and team settings is enabled

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 255 tests  +4   3 149 ✅ +4   3m 52s ⏱️ -2s
  556 suites +1     106 💤 ±0 
  556 files   +1       0 ❌ ±0 

Results for commit e6ff059. ± Comparison against base commit 71aef39.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.

com.wire.kalium.logic.feature.message.PendingProposalSchedulerTest ‑ givenMLSSupportIsDisabled_whenSyncIsLive_thenPendingProposalIsNotCommitted[jvm]

com.wire.kalium.logic.feature.client.IsAllowedToRegisterMLSClientUseCaseTest ‑ givenAllMlsConditionsAreMet_whenUseCaseInvoked_returnsTrue[jvm]
com.wire.kalium.logic.feature.client.IsAllowedToRegisterMLSClientUseCaseTest ‑ givenMlsFeatureFlagDisabled_whenUseCaseInvoked_returnsFalse[jvm]
com.wire.kalium.logic.feature.client.IsAllowedToRegisterMLSClientUseCaseTest ‑ givenPublicKeysFailure_whenUseCaseInvoked_returnsFalse[jvm]
com.wire.kalium.logic.feature.client.IsAllowedToRegisterMLSClientUseCaseTest ‑ givenUserConfigDataNotFound_whenUseCaseInvoked_returnsFalse[jvm]
com.wire.kalium.logic.feature.client.IsAllowedToRegisterMLSClientUseCaseTest ‑ givenUserConfigMlsDisabled_whenUseCaseInvoked_returnsFalse[jvm]

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	feat/consider-team-settings-when-registering-mls-device
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	670,147.67
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	545,621,666.95
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	937,679,845.89
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,519,857.38

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.69%. Comparing base (71aef39) to head (e6ff059).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
...re/kalium/logic/featureFlags/FeatureSupportImpl.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3079      +/-   ##
===========================================
+ Coverage    52.68%   52.69%   +0.01%     
===========================================
  Files         1318     1320       +2     
  Lines        51133    51166      +33     
  Branches      4742     4746       +4     
===========================================
+ Hits         26939    26962      +23     
- Misses       22269    22277       +8     
- Partials      1925     1927       +2     

Files with missing lines	Coverage Δ
...ture/client/IsAllowedToRegisterMLSClientUseCase.kt	100.00% <100.00%> (+100.00%)	⬆️
.../logic/feature/message/PendingProposalScheduler.kt	89.36% <100.00%> (-0.23%)	⬇️
...om/wire/kalium/logic/featureFlags/KaliumConfigs.kt	100.00% <ø> (ø)
...re/kalium/logic/featureFlags/FeatureSupportImpl.kt	0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71aef39...e6ff059. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: feat/consider-team-settings-when-registering-mls-device
Commit report: 71bf78c
Test service: kalium-jvm

✅ 0 Failed, 3149 Passed, 106 Skipped, 28.48s Total Time

[MohamadJaara]

just synced with Marco and we also eed to remove the compile time flag KaliumConfig.isMLSSupportEnabled
@m-zagorski

[m-zagorski]

just synced with Marco and we also eed to remove the compile time flag KaliumConfig.isMLSSupportEnabled @m-zagorski

Could you check out now ? @MohamadJaara

[MohamadJaara]

one final change

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[MohamadJaara]

LGTM