Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump AVS to 9.10.14 (WPB-11905) #3081

Merged
merged 5 commits into from
Oct 30, 2024
Merged

chore: bump AVS to 9.10.14 (WPB-11905) #3081

merged 5 commits into from
Oct 30, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 29, 2024

TaskWPB-11905 [Android] Bump AVS to release 9.10


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Now AVS is having latest webRTC version

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Test Results

3 251 tests  ±0   3 145 ✅ ±0   4m 28s ⏱️ +2s
  555 suites ±0     106 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 40c5e02. ± Comparison against base commit 77e42a2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

🐰 Bencher Report

Branchbump-avs-4-10
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
658,664.97
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
339,335,501.22
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
925,247,282.80
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,501,477.59
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.68%. Comparing base (77e42a2) to head (40c5e02).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3081      +/-   ##
===========================================
- Coverage    52.68%   52.68%   -0.01%     
===========================================
  Files         1320     1320              
  Lines        51165    51165              
  Branches      4744     4744              
===========================================
- Hits         26958    26957       -1     
- Misses       22280    22282       +2     
+ Partials      1927     1926       -1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e42a2...40c5e02. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 29, 2024

Datadog Report

Branch report: bump-avs-4-10
Commit report: ac87994
Test service: kalium-jvm

✅ 0 Failed, 3145 Passed, 106 Skipped, 33.68s Total Time

@ohassine ohassine changed the title chore: bump AVS to 9.10.13 (WPB-11905) chore: bump AVS to 9.10.14 (WPB-11905) Oct 30, 2024
Copy link

@MohamadJaara MohamadJaara added this pull request to the merge queue Oct 30, 2024
Merged via the queue into develop with commit 1f3c946 Oct 30, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the bump-avs-4-10 branch October 30, 2024 13:21
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. 👕 size: XS type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants