-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metrics for sync engine slow and incremental (WPB-11199) #3086
Conversation
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3086 +/- ##
===========================================
+ Coverage 52.69% 52.73% +0.03%
===========================================
Files 1320 1321 +1
Lines 51166 51206 +40
Branches 4746 4747 +1
===========================================
+ Hits 26963 27001 +38
- Misses 22276 22279 +3
+ Partials 1927 1926 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3149 Passed, 106 Skipped, 33.86s Total Time |
Quality Gate passedIssues Measures |
…3086) * feat: add base for metrics, implement in slow sync * feat: add base for metrics, implement in slow sync * feat: add metrics for slow sync and improve json log * feat: incremental sync logs * feat: incremental sync logs * feat: incremental sync logs, improv for foreground * feat: refactor some naming to clarify * feat: refactor some naming to clarify * feat: docs
…3086) (#3090) * feat: add base for metrics, implement in slow sync * feat: add base for metrics, implement in slow sync * feat: add metrics for slow sync and improve json log * feat: incremental sync logs * feat: incremental sync logs * feat: incremental sync logs, improv for foreground * feat: refactor some naming to clarify * feat: refactor some naming to clarify * feat: docs
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We are somehow blind in some places regarding sync
Causes (Optional)
Difficulty to troubleshoot sync problems, and no metrics regarding this, like we have in other places for example for events.
Solutions
.runningFold
Testing
Test Coverage (Optional)
How to Test
Interact with the app and see logs formatted in Datadog (not available if you don't have local setup of credentials)
Notes (Optional)
Dashboards in DD will follow.
https://app.datadoghq.eu/dashboard/crc-suh-fq6/android-sync-manager-performance?fromUser=false&refresh_mode=sliding&from_ts=1730463823807&to_ts=1730478223807&live=true
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.