Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add use case to get all ConversationDetailsWithEvents for not paginated list [WPB-12070] 🍒 #3088

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 4, 2024

StoryWPB-12070 [Android] place conversation pagination in a feature flag

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

this PR revet the changes for paginated conversation list

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…ginated list [WPB-12070] (#3085)

* fix: add use case to get all ConversationDetailsWithEvents for not paginated list

* tests

* address PR comments

* pr comment

---------

Co-authored-by: Michał Saleniuk <[email protected]>
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 5, 2024
@yamilmedina yamilmedina requested review from a team, m-zagorski, alexandreferris, MohamadJaara, saleniuk and damian-kaczmarek and removed request for a team November 6, 2024 16:40
@yamilmedina yamilmedina enabled auto-merge November 6, 2024 16:40
Copy link

sonarqubecloud bot commented Nov 6, 2024

Copy link
Contributor Author

github-actions bot commented Nov 6, 2024

Test Results

3 258 tests   - 2   3 151 ✅  - 3   4m 0s ⏱️ -22s
  557 suites ±0     107 💤 +1 
  557 files   ±0       0 ❌ ±0 

Results for commit 698b467. ± Comparison against base commit 77bf609.

This pull request removes 3 and adds 1 tests. Note that renamed tests count towards both.
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAConversationHasLastMessageAndDraft_whenObservingConversationListDetails_ThenCorrectlyGetLastMessage[jvm]
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAOneToOneConversationHasNewMessages_whenObservingConversationListDetails_ThenCorrectlyGetUnreadMessageCount[jvm]
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAOneToOneConversationHasNotNewMessages_whenGettingConversationDetails_ThenReturnZeroUnreadMessageCount[jvm]
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAGroupConversationHasNewMessages_whenObservingConversationListDetails_ThenCorrectlyGetUnreadMessageCount[jvm]
This pull request skips 1 test.
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAGroupConversationHasNotNewMessages_whenGettingConversationDetails_ThenReturnZeroUnreadMessageCount[jvm]

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

github-actions bot commented Nov 6, 2024

🐰 Bencher Report

Branchfix/add-usecase-to-get-conversationdetailswithevents-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
686,523.08
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
513,743,968.07
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
923,687,951.89
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,849,367.62
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/add-usecase-to-get-conversationdetailswithevents-cherry-pick
Commit report: 9fcd793
Test service: kalium-jvm

✅ 0 Failed, 3151 Passed, 107 Skipped, 30.03s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.71%. Comparing base (77bf609) to head (698b467).

Files with missing lines Patch % Lines
.../logic/data/conversation/ConversationRepository.kt 80.00% 2 Missing and 2 partials ⚠️
...rveConversationListDetailsWithEventsUseCaseImpl.kt 0.00% 3 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3088      +/-   ##
===========================================
- Coverage    52.73%   52.71%   -0.02%     
===========================================
  Files         1321     1322       +1     
  Lines        51211    51227      +16     
  Branches      4748     4752       +4     
===========================================
+ Hits         27004    27006       +2     
- Misses       22281    22293      +12     
- Partials      1926     1928       +2     
Files with missing lines Coverage Δ
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...rveConversationListDetailsWithEventsUseCaseImpl.kt 0.00% <0.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt 62.55% <80.00%> (+0.51%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77bf609...698b467. Read the comment docs.

@yamilmedina yamilmedina added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit 71ecfab Nov 7, 2024
22 checks passed
@yamilmedina yamilmedina deleted the fix/add-usecase-to-get-conversationdetailswithevents-cherry-pick branch November 7, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants