-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add use case to get all ConversationDetailsWithEvents for not paginated list [WPB-12070] 🍒 #3088
fix: add use case to get all ConversationDetailsWithEvents for not paginated list [WPB-12070] 🍒 #3088
Conversation
…ginated list [WPB-12070] (#3085) * fix: add use case to get all ConversationDetailsWithEvents for not paginated list * tests * address PR comments * pr comment --------- Co-authored-by: Michał Saleniuk <[email protected]>
…swithevents-cherry-pick
Quality Gate passedIssues Measures |
Test Results3 258 tests - 2 3 151 ✅ - 3 4m 0s ⏱️ -22s Results for commit 698b467. ± Comparison against base commit 77bf609. This pull request removes 3 and adds 1 tests. Note that renamed tests count towards both.
This pull request skips 1 test.
♻️ This comment has been updated with latest results. |
Bencher Report
Click to view all benchmark results
|
Datadog ReportBranch report: ✅ 0 Failed, 3151 Passed, 107 Skipped, 30.03s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3088 +/- ##
===========================================
- Coverage 52.73% 52.71% -0.02%
===========================================
Files 1321 1322 +1
Lines 51211 51227 +16
Branches 4748 4752 +4
===========================================
+ Hits 27004 27006 +2
- Misses 22281 22293 +12
- Partials 1926 1928 +2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
this PR revet the changes for paginated conversation list
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.