feat: Implement message unknown strategy #WPB-11913

[m-zagorski]

WPB-11913 [Android] - Implement RFC - Message handling - Incall reactions / Hand raising

https://wearezeta.atlassian.net/browse/WPB-11913

What's new in this PR?

Issues

Implement Unknown messages RFC

Solutions

Add a new optional proto field for GenericMessage.
Basically right now we're handling incoming messages that will support UnknownStrategy
Unless we know the type of added message we cant really implement a strategy to bring back the stored byte data into real content.
Also I did not implement adding the UnknownStrategy for current messages as stated in the rfc document.

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[m-zagorski]

@vitorhugods Could you take a looks since you're the author of the RFC, if those changes meet the requirements. I was looking if we could implement the strategy for decoding those stored unknown bytes, but until we have the types it might not be possible - but maybe you had something in mind?

[github-actions]

Test Results

3 264 tests  +4   3 158 ✅ +4   4m 19s ⏱️ -3s
  557 suites ±0     106 💤 ±0 
  557 files   ±0       0 ❌ ±0 

Results for commit 0e5a86e. ± Comparison against base commit 77bf609.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	feat/message-unknown-strategy
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	654,716.94
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	323,126,216.31
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	928,538,986.49
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,217,095.91

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.74%. Comparing base (77bf609) to head (0e5a86e).

Files with missing lines	Patch %	Lines
...re/kalium/logic/data/message/ProtoContentMapper.kt	91.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3092      +/-   ##
===========================================
+ Coverage    52.73%   52.74%   +0.01%     
===========================================
  Files         1321     1321              
  Lines        51211    51245      +34     
  Branches      4748     4758      +10     
===========================================
+ Hits         27004    27030      +26     
- Misses       22281    22283       +2     
- Partials      1926     1932       +6     

Files with missing lines	Coverage Δ
...re/kalium/logic/data/message/ProtoContentMapper.kt	65.36% <91.66%> (+1.27%)	⬆️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77bf609...0e5a86e. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: feat/message-unknown-strategy
Commit report: cd0397a
Test service: kalium-jvm

✅ 0 Failed, 3158 Passed, 106 Skipped, 33.72s Total Time

[vitorhugods]

Nice :)