Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable x86 support [WPB-11427] #3094

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 7, 2024

StoryWPB-11427 [Android] drop support for x86


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

disable x86 support

Testing

try to run the app on x86 emulator it should not install

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Nov 7, 2024
Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Results

3 252 tests  ±0   3 145 ✅ ±0   4m 31s ⏱️ -6s
  555 suites ±0     107 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit c8258b6. ± Comparison against base commit b7bdcea.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.61%. Comparing base (b7bdcea) to head (c8258b6).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3094      +/-   ##
=====================================================
- Coverage              52.61%   52.61%   -0.01%     
=====================================================
  Files                   1320     1320              
  Lines                  51515    51515              
  Branches                4779     4779              
=====================================================
- Hits                   27105    27104       -1     
- Misses                 22448    22449       +1     
  Partials                1962     1962              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7bdcea...c8258b6. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/disable-x86-support
Commit report: 95465f8
Test service: kalium-jvm

✅ 0 Failed, 3145 Passed, 107 Skipped, 32.94s Total Time

@MohamadJaara MohamadJaara added echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... and removed echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Nov 8, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 12, 2024
Merged via the queue into release/candidate with commit b632ada Nov 12, 2024
21 checks passed
@MohamadJaara MohamadJaara deleted the feat/disable-x86-support branch November 12, 2024 17:04
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2024
Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... 👕 size: S type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants