Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust used JDK name for deployment of testservice (WPB-14267) #3101

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mythsunwind
Copy link
Collaborator

@mythsunwind mythsunwind commented Nov 13, 2024

BugWPB-14267 Kalium testservice fails to deploy


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We currently cannot deploy kalium testservice anymore.

Causes (Optional)

I renamed the tool name from AdoptiumJDK17 to JDK17 in Jenkins to streamline settings.

Solutions

Renamed it in the Jenkinsfile

@mythsunwind mythsunwind changed the title fix: Adjust used JDK name for deployment of testservice fix: Adjust used JDK name for deployment of testservice (WPB-14267) Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

Test Results

3 265 tests  ±0   3 158 ✅ ±0   4m 15s ⏱️ +4s
  557 suites ±0     107 💤 ±0 
  557 files   ±0       0 ❌ ±0 

Results for commit 609557d. ± Comparison against base commit 544c802.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchtestservice-deployment-fix
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
654,964.78
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
602,974,205.04
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
927,057,493.44
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,286,656.60
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.19%. Comparing base (544c802) to head (609557d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3101      +/-   ##
===========================================
- Coverage    54.20%   54.19%   -0.01%     
===========================================
  Files         1196     1196              
  Lines        35592    35592              
  Branches      3625     3625              
===========================================
- Hits         19291    19290       -1     
- Misses       14897    14898       +1     
  Partials      1404     1404              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544c802...609557d. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: testservice-deployment-fix
Commit report: fc7123e
Test service: kalium-jvm

✅ 0 Failed, 3158 Passed, 107 Skipped, 29.59s Total Time

@mythsunwind mythsunwind added this pull request to the merge queue Nov 13, 2024
Merged via the queue into develop with commit f883583 Nov 13, 2024
28 of 29 checks passed
@mythsunwind mythsunwind deleted the testservice-deployment-fix branch November 13, 2024 09:57
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants