feat: connect to upgrade-personal-to-team API #WPB-11992 #3103

damian-kaczmarek · 2024-11-13T15:40:46Z

WPB-11992 [Android] Team creation for personal user - connect to the API - /upgrade-personal-to-team

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adds calls to the API when migrating from personal to team account.

Needs releases with:

api v7

Testing

Test Coverage (Optional)

Work in Progress

I have added automated test to this contribution

How to Test

To test you need to switch to anta
https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/300351887/Testing+environments+for+federation#anta

The html with deeplinks switching can be downloaded here. You must logout first before switching. https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/300351887/Testing+environments+for+federation#anta

To get signup code you must read the email from inbucket.
Password is on 1password.

Then:

create personal account
go to you profile page, at the top you will see migration banner
go through the process
at the you should see success screen
currently you will only see changes to your account after app restart, WIP: https://wearezeta.atlassian.net/browse/WPB-12187

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…re/api-v7

github-actions · 2024-11-13T16:01:07Z

Test Results

3 299 tests +10 3 192 ✅ +10 5m 12s ⏱️ +2s
563 suites + 2 107 💤 ± 0
563 files + 2 0 ❌ ± 0

Results for commit e8b7477. ± Comparison against base commit 3bf74f0.

♻️ This comment has been updated with latest results.

datadog-wireapp · 2024-11-13T16:13:56Z

Datadog Report

Branch report: feature/upgrade-persona-team-api
Commit report: 0a755dd
Test service: kalium-jvm

✅ 0 Failed, 3192 Passed, 107 Skipped, 34.05s Total Time

…o feature/upgrade-persona-team-api

codecov-commenter · 2024-11-14T13:03:03Z

Codecov Report

Attention: Patch coverage is 41.90476% with 61 lines in your changes missing coverage. Please review.

Project coverage is 54.03%. Comparing base (3bf74f0) to head (e8b7477).

Files with missing lines	Patch %	Lines
...mocks/responses/MigrationUserToTeamResponseJson.kt	0.00%	31 Missing ⚠️
...etwork/api/authenticated/user/CreateUserTeamDTO.kt	0.00%	5 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV0.kt	0.00%	3 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV2.kt	0.00%	3 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV3.kt	0.00%	3 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV4.kt	0.00%	3 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV5.kt	0.00%	3 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV6.kt	0.00%	3 Missing ⚠️
...etworkContainer/AuthenticatedNetworkContainerV7.kt	0.00%	3 Missing ⚠️
...api/base/authenticated/UpgradePersonalToTeamApi.kt	0.00%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3103      +/-   ##
===========================================
- Coverage    54.07%   54.03%   -0.05%     
===========================================
  Files         1232     1244      +12     
  Lines        36006    36111     +105     
  Branches      3653     3653              
===========================================
+ Hits         19469    19511      +42     
- Misses       15128    15190      +62     
- Partials      1409     1410       +1

Files with missing lines	Coverage Δ
.../com/wire/kalium/logic/data/user/UserRepository.kt	`68.65% <100.00%> (+0.96%)`	⬆️
...user/migration/MigrateFromPersonalToTeamUseCase.kt	`100.00% <100.00%> (ø)`
...api/v2/authenticated/UpgradePersonalToTeamApiV2.kt	`100.00% <100.00%> (ø)`
...api/v3/authenticated/UpgradePersonalToTeamApiV3.kt	`100.00% <100.00%> (ø)`
...api/v4/authenticated/UpgradePersonalToTeamApiV4.kt	`100.00% <100.00%> (ø)`
...api/v5/authenticated/UpgradePersonalToTeamApiV5.kt	`100.00% <100.00%> (ø)`
...api/v6/authenticated/UpgradePersonalToTeamApiV6.kt	`100.00% <100.00%> (ø)`
...api/v7/authenticated/UpgradePersonalToTeamApiV7.kt	`100.00% <100.00%> (ø)`
.../networkContainer/AuthenticatedNetworkContainer.kt	`24.50% <ø> (ø)`
.../com/wire/kalium/logic/data/user/CreateUserTeam.kt	`0.00% <0.00%> (ø)`
... and 11 more

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf74f0...e8b7477. Read the comment docs.

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

logic/src/commonMain/kotlin/com/wire/kalium/logic/data/user/UserRepository.kt

ohassine · 2024-11-18T17:00:26Z

...Main/kotlin/com/wire/kalium/logic/feature/user/migration/MigrateFromPersonalToTeamUseCase.kt

+}
+
+sealed class MigrateFromPersonalToTeamResult {
+    data class Success(val teamId: String, val teamName: String) : MigrateFromPersonalToTeamResult()


Do we need to pass to the app teamId and teamName ?, the app is already having those values

Removed id as we don't use it. Left the team name and updated the state just in case API somehow changed the name

Yeah but API should not change a name provided by the user

logic/src/commonMain/kotlin/com/wire/kalium/logic/data/user/UserRepository.kt

...commonMain/kotlin/com/wire/kalium/network/api/v4/authenticated/UpgradePersonalToTeamApiV4.kt

Co-authored-by: Oussama Hassine <[email protected]>

…re/upgrade-persona-team-api

…sona-team-api' into feature/upgrade-persona-team-api

…re/upgrade-persona-team-api # Conflicts: # network/src/commonMain/kotlin/com/wire/kalium/network/api/v7/authenticated/networkContainer/AuthenticatedNetworkContainerV7.kt

sonarqubecloud · 2024-11-20T08:00:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-11-20T08:15:26Z

Bencher Report

Branch	feature/upgrade-persona-team-api
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!
Without a Threshold, no Alerts will ever be generated.
Latency (nanoseconds (ns))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	662,181.38
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	356,749,576.53
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,317,534,923.11
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,494,165.36

🐰 View full continuous benchmarking report in Bencher

damian-kaczmarek added 9 commits November 8, 2024 14:04

add v7

cabcc1d

capabilities update

d824dba

remove too much copied code

6351438

one2one paths change

98002e1

revert magic number Suppress

4189e4c

Merge remote-tracking branch 'refs/remotes/origin/develop' into featu…

43d27eb

…re/api-v7

tests and CR changes

e3927d8

feature: connect to upgrade-personal-to-team API #WPB-11992

31265e6

self review

f60103a

damian-kaczmarek self-assigned this Nov 13, 2024

echoes-hq bot added the echoes/initiative: personal-users-to-team-users... label Nov 13, 2024

github-actions bot added the Fix PR Title 🤦‍♂️ label Nov 13, 2024

damian-kaczmarek mentioned this pull request Nov 13, 2024

feat: connect to upgrade-personal-to-team API #WPB-11992 wireapp/wire-android#3625

Merged

7 tasks

github-actions bot added 🚨 Potential breaking changes 👕 size: XL labels Nov 13, 2024

damian-kaczmarek changed the title ~~feature: connect to upgrade-personal-to-team API #WPB-11992~~ feat: connect to upgrade-personal-to-team API #WPB-11992 Nov 13, 2024

github-actions bot removed the Fix PR Title 🤦‍♂️ label Nov 13, 2024

detekt

de4bc40

github-actions bot added the type: feature ✨ label Nov 13, 2024

damian-kaczmarek added 7 commits November 14, 2024 12:51

fix ConversationResponse versions usage for notifications

c1729c1

Merge remote-tracking branch 'refs/remotes/origin/feature/api-v7' int…

de80e42

…o feature/upgrade-persona-team-api

detekt

f520d26

Merge remote-tracking branch 'refs/remotes/origin/feature/api-v7' int…

3c4f4e1

…o feature/upgrade-persona-team-api

fix test

2c383ac

Merge remote-tracking branch 'refs/remotes/origin/feature/api-v7' int…

63ea6a9

…o feature/upgrade-persona-team-api

test fix

55fa044

added tests

87b0a25

detekt

3249de2

github-actions bot added 👕 size: XXL and removed 👕 size: XL labels Nov 18, 2024

revert code formatting

90af792

github-actions bot added 👕 size: XL and removed 👕 size: XXL labels Nov 18, 2024

revert code formatting

efffa6e

damian-kaczmarek marked this pull request as ready for review November 18, 2024 07:12

damian-kaczmarek requested review from saleniuk and ohassine November 18, 2024 07:12

test fix

b2e0cf4

ohassine requested changes Nov 18, 2024

View reviewed changes

Base automatically changed from feature/api-v7 to develop November 18, 2024 17:47

damian-kaczmarek and others added 7 commits November 19, 2024 13:42

wrong extended class

2db6c6e

Co-authored-by: Oussama Hassine <[email protected]>

Merge remote-tracking branch 'refs/remotes/origin/develop' into featu…

29af93a

…re/upgrade-persona-team-api

Merge remote-tracking branch 'refs/remotes/origin/feature/upgrade-per…

234cfb0

…sona-team-api' into feature/upgrade-persona-team-api

CR changes

5711022

CR

01da6ac

Merge remote-tracking branch 'refs/remotes/origin/develop' into featu…

c37eb15

…re/upgrade-persona-team-api # Conflicts: # network/src/commonMain/kotlin/com/wire/kalium/network/api/v7/authenticated/networkContainer/AuthenticatedNetworkContainerV7.kt

detekt

e8b7477

ohassine approved these changes Nov 20, 2024

View reviewed changes

vitorhugods approved these changes Nov 20, 2024

View reviewed changes

ohassine added this pull request to the merge queue Nov 20, 2024

Merged via the queue into develop with commit 2dccbfe Nov 20, 2024
22 checks passed

ohassine deleted the feature/upgrade-persona-team-api branch November 20, 2024 12:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: connect to upgrade-personal-to-team API #WPB-11992 #3103

feat: connect to upgrade-personal-to-team API #WPB-11992 #3103

damian-kaczmarek commented Nov 13, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

datadog-wireapp bot commented Nov 13, 2024 •

edited

Loading

codecov-commenter commented Nov 14, 2024 •

edited

Loading

ohassine Nov 18, 2024 •

edited

Loading

damian-kaczmarek Nov 19, 2024

ohassine Nov 20, 2024

sonarqubecloud bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

⚠️ WARNING: No Threshold found!

feat: connect to upgrade-personal-to-team API #WPB-11992 #3103

feat: connect to upgrade-personal-to-team API #WPB-11992 #3103

Conversation

damian-kaczmarek commented Nov 13, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Testing

Test Coverage (Optional)

How to Test

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Nov 13, 2024 • edited Loading

Test Results

datadog-wireapp bot commented Nov 13, 2024 • edited Loading

Datadog Report

codecov-commenter commented Nov 14, 2024 • edited Loading

Codecov Report

ohassine Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

damian-kaczmarek Nov 19, 2024

Choose a reason for hiding this comment

ohassine Nov 20, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 20, 2024

Quality Gate passed

github-actions bot commented Nov 20, 2024

Bencher Report

⚠️ WARNING: No Threshold found!

damian-kaczmarek commented Nov 13, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Nov 13, 2024 •

edited

Loading

datadog-wireapp bot commented Nov 13, 2024 •

edited

Loading

codecov-commenter commented Nov 14, 2024 •

edited

Loading

ohassine Nov 18, 2024 •

edited

Loading