Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Recently ended call metadata [WPB-14256] #3112

Merged
merged 10 commits into from
Dec 17, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 20, 2024

StoryWPB-14256 [Android] Call end - Event and segmentation

https://wearezeta.atlassian.net/browse/WPB-14256

What's new in this PR?

Issues

We need to add Call ended segementation

Causes (Optional)

We need raw end call cause and a lot of data. In this PR we're storing recently ended call and give an use case
to create the metadata. I've also have the compact version of it (I will link it shortly) that is creating the metadata right away.

Solutions

Pick up all the things we need, prepare metadata and allow clients to observe them to use them in the analytics


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@m-zagorski m-zagorski changed the title Feat/recently ended call metadata feat: Rcently ended call metadata [WPB-14256] Nov 20, 2024
@m-zagorski m-zagorski changed the title feat: Rcently ended call metadata [WPB-14256] feat: Recently ended call metadata [WPB-14256] Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Test Results

3 346 tests  +5   3 239 ✅ +5   5m 5s ⏱️ -38s
  573 suites +1     107 💤 ±0 
  573 files   +1       0 ❌ ±0 

Results for commit 520f396. ± Comparison against base commit 5396afa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 20, 2024

Datadog Report

Branch report: feat/recently-ended-call-metadata
Commit report: bdb4b08
Test service: kalium-jvm

✅ 0 Failed, 3239 Passed, 107 Skipped, 59.53s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 42.42424% with 57 lines in your changes missing coverage. Please review.

Project coverage is 54.08%. Comparing base (5396afa) to head (520f396).

Files with missing lines Patch % Lines
...alium/logic/data/call/RecentlyEndedCallMetadata.kt 0.00% 20 Missing ⚠️
.../com/wire/kalium/logic/data/call/CallRepository.kt 10.00% 18 Missing ⚠️
...reateAndPersistRecentlyEndedCallMetadataUseCase.kt 75.00% 1 Missing and 10 partials ⚠️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% 3 Missing ⚠️
...usecase/ObserveRecentlyEndedCallMetadataUseCase.kt 0.00% 3 Missing ⚠️
.../kalium/logic/feature/call/scenario/OnCloseCall.kt 85.71% 0 Missing and 1 partial ⚠️
...om/wire/kalium/logic/feature/search/SearchScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3112      +/-   ##
===========================================
- Coverage    54.11%   54.08%   -0.04%     
===========================================
  Files         1252     1255       +3     
  Lines        36519    36613      +94     
  Branches      3699     3713      +14     
===========================================
+ Hits         19763    19801      +38     
- Misses       15331    15377      +46     
- Partials      1425     1435      +10     
Files with missing lines Coverage Δ
.../kalium/logic/feature/search/SearchUsersUseCase.kt 95.34% <100.00%> (ø)
.../kalium/logic/feature/call/scenario/OnCloseCall.kt 85.71% <85.71%> (+1.62%) ⬆️
...om/wire/kalium/logic/feature/search/SearchScope.kt 0.00% <0.00%> (ø)
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% <0.00%> (ø)
...usecase/ObserveRecentlyEndedCallMetadataUseCase.kt 0.00% <0.00%> (ø)
...reateAndPersistRecentlyEndedCallMetadataUseCase.kt 75.00% <75.00%> (ø)
.../com/wire/kalium/logic/data/call/CallRepository.kt 84.14% <10.00%> (-3.58%) ⬇️
...alium/logic/data/call/RecentlyEndedCallMetadata.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5396afa...520f396. Read the comment docs.

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge in 4.11

Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@m-zagorski m-zagorski enabled auto-merge December 13, 2024 08:28
@m-zagorski m-zagorski added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit 8efbb07 Dec 17, 2024
23 checks passed
@m-zagorski m-zagorski deleted the feat/recently-ended-call-metadata branch December 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants