-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Recently ended call metadata [WPB-14256] #3112
Conversation
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallRepository.kt
Outdated
Show resolved
Hide resolved
|
Branch | feat/recently-ended-call-metadata |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
CLI flag.
Click to view all benchmark results
Benchmark | Latency | nanoseconds (ns) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 662,459.74 |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 340,991,610.20 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,326,802,984.17 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,531,953.97 |
Datadog ReportBranch report: ✅ 0 Failed, 3239 Passed, 107 Skipped, 59.53s Total Time |
...m/wire/kalium/logic/feature/call/usecase/CreateAndPersistRecentlyEndedCallMetadataUseCase.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please merge in 4.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me :)
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallRepository.kt
Outdated
Show resolved
Hide resolved
|
https://wearezeta.atlassian.net/browse/WPB-14256
What's new in this PR?
Issues
We need to add
Call ended
segementationCauses (Optional)
We need raw end call cause and a lot of data. In this PR we're storing recently ended call and give an use case
to create the metadata. I've also have the
compact
version of it (I will link it shortly) that is creating the metadata right away.Solutions
Pick up all the things we need, prepare metadata and allow clients to observe them to use them in the analytics
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.