Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delete group as admin [WPB-11559] #3115

Closed
wants to merge 1 commit into from

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 20, 2024

StoryWPB-11559 [Android] Delete a group as admin

https://wearezeta.atlassian.net/browse/WPB-11559

What's new in this PR?

Issues

We want to allow admins to delete group conversations

Solutions

In order to delete group as an admin, we have to be in the same team, so we need to know our own team id, to later
check in the client if were matching the team


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Test Results

3 299 tests  ±0   3 192 ✅ ±0   4m 44s ⏱️ -22s
  563 suites ±0     107 💤 ±0 
  563 files   ±0       0 ❌ ±0 

Results for commit 2938636. ± Comparison against base commit 2dccbfe.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchfeat/delete-group-as-admin
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
657,773.80
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
402,857,251.60
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,323,122,582.06
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,746,231.31
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.03%. Comparing base (3bf74f0) to head (2938636).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...a/conversation/ConversationRepositoryExtensions.kt 50.00% 2 Missing ⚠️
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% 1 Missing ⚠️
.../logic/data/conversation/ConversationRepository.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3115      +/-   ##
===========================================
- Coverage    54.07%   54.03%   -0.04%     
===========================================
  Files         1232     1245      +13     
  Lines        36006    36141     +135     
  Branches      3653     3652       -1     
===========================================
+ Hits         19469    19528      +59     
- Misses       15128    15205      +77     
+ Partials      1409     1408       -1     
Files with missing lines Coverage Δ
...lium/logic/data/conversation/ConversationMapper.kt 57.97% <100.00%> (+0.12%) ⬆️
...nversation/folders/ConversationFolderRepository.kt 91.48% <100.00%> (+0.18%) ⬆️
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% <0.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt 62.87% <83.33%> (+0.50%) ⬆️
...a/conversation/ConversationRepositoryExtensions.kt 84.00% <50.00%> (-2.96%) ⬇️

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf74f0...2938636. Read the comment docs.

---- 🚨 Try these New Features:

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/delete-group-as-admin
Commit report: e3e0044
Test service: kalium-jvm

✅ 0 Failed, 3192 Passed, 107 Skipped, 33.63s Total Time

@@ -299,7 +299,7 @@ sealed class ConversationDetails(open val conversation: Conversation) {
override val conversation: Conversation,
val hasOngoingCall: Boolean = false,
val isSelfUserMember: Boolean,
val isSelfUserCreator: Boolean,
val selfUserTeamId: TeamId?,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add the user self team ID to the conversation model, since it is fixed and is not really conversation related, if you need it in the UI part to get whether a conversation can be deleted or not, please expose it as its own use case and use it in the UI

@m-zagorski m-zagorski closed this Nov 21, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants