-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delete group as admin [WPB-11559] #3115
Conversation
Quality Gate passedIssues Measures |
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3115 +/- ##
===========================================
- Coverage 54.07% 54.03% -0.04%
===========================================
Files 1232 1245 +13
Lines 36006 36141 +135
Branches 3653 3652 -1
===========================================
+ Hits 19469 19528 +59
- Misses 15128 15205 +77
+ Partials 1409 1408 -1
... and 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3192 Passed, 107 Skipped, 33.63s Total Time |
@@ -299,7 +299,7 @@ sealed class ConversationDetails(open val conversation: Conversation) { | |||
override val conversation: Conversation, | |||
val hasOngoingCall: Boolean = false, | |||
val isSelfUserMember: Boolean, | |||
val isSelfUserCreator: Boolean, | |||
val selfUserTeamId: TeamId?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to add the user self team ID to the conversation model, since it is fixed and is not really conversation related, if you need it in the UI part to get whether a conversation can be deleted or not, please expose it as its own use case and use it in the UI
https://wearezeta.atlassian.net/browse/WPB-11559
What's new in this PR?
Issues
We want to allow admins to delete group conversations
Solutions
In order to delete group as an admin, we have to be in the same team, so we need to know our own team id, to later
check in the client if were matching the team
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.