Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update teamId after migrating from personal to team account (WPB-12187) #3120

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 21, 2024

TaskWPB-12187 [Android] update team id cache when joining a team


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After migration from personal to team account, we need to store teamId and invalidate the cached value

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Test Results

3 327 tests  ±0   3 220 ✅ ±0   5m 32s ⏱️ +46s
  569 suites ±0     107 💤 ±0 
  569 files   ±0       0 ❌ ±0 

Results for commit 7299cdf. ± Comparison against base commit c7b96a2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.14%. Comparing base (c7b96a2) to head (7299cdf).

Files with missing lines Patch % Lines
.../com/wire/kalium/logic/data/user/UserRepository.kt 25.00% 3 Missing ⚠️
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 0.00% 2 Missing ⚠️
.../com/wire/kalium/logic/data/user/CreateUserTeam.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3120      +/-   ##
===========================================
- Coverage    54.14%   54.14%   -0.01%     
===========================================
  Files         1249     1249              
  Lines        36272    36281       +9     
  Branches      3658     3658              
===========================================
+ Hits         19641    19643       +2     
- Misses       15219    15225       +6     
- Partials      1412     1413       +1     
Files with missing lines Coverage Δ
...user/migration/MigrateFromPersonalToTeamUseCase.kt 100.00% <100.00%> (ø)
.../kotlin/com/wire/kalium/persistence/dao/UserDAO.kt 96.33% <ø> (ø)
.../com/wire/kalium/logic/data/user/CreateUserTeam.kt 0.00% <0.00%> (ø)
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 52.47% <0.00%> (-0.35%) ⬇️
.../com/wire/kalium/logic/data/user/UserRepository.kt 68.04% <25.00%> (-0.61%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b96a2...7299cdf. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 22, 2024

Datadog Report

Branch report: update-team-id-after-migratiom-to-team
Commit report: 924426c
Test service: kalium-jvm

✅ 0 Failed, 3220 Passed, 107 Skipped, 44.38s Total Time

@ohassine ohassine enabled auto-merge November 26, 2024 08:53
@ohassine ohassine added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 26, 2024
@ohassine ohassine added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 786a7b8 Nov 26, 2024
21 checks passed
@ohassine ohassine deleted the update-team-id-after-migratiom-to-team branch November 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants