Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support other message types [WPB-10575] #3122

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Nov 22, 2024

StoryWPB-10575 Cross Platform Backup: Write common backup / restore library


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Extend support to other message types, like Assets and Location.

Solutions

Rely for now on the most certain data. We can fine-tune this with other clients later.

Dependencies

Needs releases with:

Testing

Test Coverage

  • I have added automated test to this contribution

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods force-pushed the feat/support-other-message-types branch 2 times, most recently from c454a1e to 8b78c9b Compare November 22, 2024 03:15
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Test Results

3 313 tests   3 206 ✅  5m 19s ⏱️
  566 suites    107 💤
  566 files        0 ❌

Results for commit 6157bf2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic/multiplatform-backup@ccb8193). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             epic/multiplatform-backup    #3122   +/-   ##
============================================================
  Coverage                             ?   54.03%           
============================================================
  Files                                ?     1246           
  Lines                                ?    36152           
  Branches                             ?     3656           
============================================================
  Hits                                 ?    19535           
  Misses                               ?    15207           
  Partials                             ?     1410           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb8193...6157bf2. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 22, 2024

Datadog Report

Branch report: feat/support-other-message-types
Commit report: c100eee
Test service: kalium-jvm

✅ 0 Failed, 3206 Passed, 107 Skipped, 38.65s Total Time

@vitorhugods vitorhugods changed the base branch from develop to epic/multiplatform-backup November 22, 2024 12:26
@vitorhugods vitorhugods force-pushed the feat/support-other-message-types branch 2 times, most recently from 41a7dd2 to a35c722 Compare November 22, 2024 12:30
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 29, 2024
vitorhugods and others added 3 commits December 2, 2024 16:54
* feat: add metadata for assetd

* feat: add metadata for assetd

* fix: detekt

* feat: metadata logs

* feat: generic metadata for images
@vitorhugods vitorhugods force-pushed the feat/support-other-message-types branch from 8a7a13f to 6157bf2 Compare December 2, 2024 15:57
@vitorhugods vitorhugods marked this pull request as ready for review December 2, 2024 15:58
Copy link

sonarqubecloud bot commented Dec 2, 2024

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@vitorhugods vitorhugods merged commit f16d679 into epic/multiplatform-backup Dec 5, 2024
21 checks passed
@vitorhugods vitorhugods deleted the feat/support-other-message-types branch December 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants