Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🍒 from develop - more logs sending message #WPB-11601 #3127

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Nov 26, 2024

BugWPB-11601 [Android] Message stuck on sending

(cherry picked from commit 2ddb183

What's new in this PR?

Issues

Cherry pick from develop #3109 so it can be available faster
add more logs for sending message


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Nov 26, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 26, 2024
@damian-kaczmarek damian-kaczmarek changed the title chore: android gradle plugin update (#3064) chore: 🍒 from develop - more logs sending message #WPB-11601 Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Test Results

3 264 tests  ±0   3 157 ✅ ±0   5m 10s ⏱️ +42s
  555 suites ±0     107 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 8d18a4d. ± Comparison against base commit 7440f44.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (7440f44) to head (8d18a4d).

Files with missing lines Patch % Lines
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 27.27% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3127      +/-   ##
=====================================================
+ Coverage              52.64%   52.65%   +0.01%     
=====================================================
  Files                   1321     1321              
  Lines                  51615    51621       +6     
  Branches                4781     4784       +3     
=====================================================
+ Hits                   27172    27181       +9     
+ Misses                 22487    22481       -6     
- Partials                1956     1959       +3     
Files with missing lines Coverage Δ
...wire/kalium/logic/feature/message/MessageSender.kt 94.16% <100.00%> (+0.04%) ⬆️
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 32.53% <27.27%> (+2.28%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7440f44...8d18a4d. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/add-more-sending-debug
Commit report: 57af389
Test service: kalium-jvm

✅ 0 Failed, 3157 Passed, 107 Skipped, 37.14s Total Time

@damian-kaczmarek damian-kaczmarek marked this pull request as ready for review November 26, 2024 10:36
@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Nov 27, 2024
Merged via the queue into release/candidate with commit c7f4257 Nov 27, 2024
26 of 27 checks passed
@damian-kaczmarek damian-kaczmarek deleted the chore/add-more-sending-debug branch November 27, 2024 11:02
@echoes-hq echoes-hq bot added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 🚨 Potential breaking changes 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants