Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Proteus federation if MLS not supported by backend (WPB-14456) 🍒 #3132

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 27, 2024

StoryWPB-14456 [Android] Still allow usage of federation for proteus in some cases

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to support federation search, according to if MLS is enabled, or if it is configured or not in the backend.

Solutions

Create a new use case centralizing the logic to decide if we need to support federation or not for this: team/conversation/backend.

Before the logic was in the view model in AR, but here is centralized and we can test all the cases for it, therefore now the view model just calls this use case to decide if we need to enable cross domain search.

Dependencies (Optional)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…-14250) (#3126)

* chore: use case template

* feat: usecase for allowing federated search

* feat: add usecase to check for federation search allowance

* feat: cleanup

* feat: adjust tests to new implementation

* feat: adjust tests to new implementation
Copy link
Contributor Author

github-actions bot commented Nov 27, 2024

Test Results

3 335 tests  +5   3 228 ✅ +5   5m 7s ⏱️ +25s
  572 suites +1     107 💤 ±0 
  572 files   +1       0 ❌ ±0 

Results for commit 5217b78. ± Comparison against base commit b7b4bd2.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.21%. Comparing base (b7b4bd2) to head (5217b78).

Files with missing lines Patch % Lines
...feature/search/IsFederationSearchAllowedUseCase.kt 72.00% 2 Missing and 5 partials ⚠️
...om/wire/kalium/logic/feature/search/SearchScope.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3132      +/-   ##
===========================================
- Coverage    54.21%   54.21%   -0.01%     
===========================================
  Files         1250     1251       +1     
  Lines        36328    36358      +30     
  Branches      3658     3668      +10     
===========================================
+ Hits         19697    19712      +15     
- Misses       15218    15227       +9     
- Partials      1413     1419       +6     
Files with missing lines Coverage Δ
...om/wire/kalium/logic/feature/search/SearchScope.kt 0.00% <0.00%> (ø)
...feature/search/IsFederationSearchAllowedUseCase.kt 72.00% <72.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b4bd2...5217b78. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/support-proteus-federation-if-mls-disabled-cherry-pick
Commit report: 8517cc3
Test service: kalium-jvm

✅ 0 Failed, 3228 Passed, 107 Skipped, 40.69s Total Time

@yamilmedina yamilmedina changed the title feat: support Proteus federation if MLS not supported by backend (WPB-14250) 🍒 feat: support Proteus federation if MLS not supported by backend (WPB-14456) 🍒 Nov 27, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Nov 29, 2024
Merged via the queue into develop with commit 4d95d50 Nov 29, 2024
25 checks passed
@yamilmedina yamilmedina deleted the feat/support-proteus-federation-if-mls-disabled-cherry-pick branch November 29, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants