-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Proteus federation if MLS not supported by backend (WPB-14456) 🍒 #3132
feat: support Proteus federation if MLS not supported by backend (WPB-14456) 🍒 #3132
Conversation
…-14250) (#3126) * chore: use case template * feat: usecase for allowing federated search * feat: add usecase to check for federation search allowance * feat: cleanup * feat: adjust tests to new implementation * feat: adjust tests to new implementation
…sabled-cherry-pick
Quality Gate passedIssues Measures |
Bencher Report
Click to view all benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3132 +/- ##
===========================================
- Coverage 54.21% 54.21% -0.01%
===========================================
Files 1250 1251 +1
Lines 36328 36358 +30
Branches 3658 3668 +10
===========================================
+ Hits 19697 19712 +15
- Misses 15218 15227 +9
- Partials 1413 1419 +6
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3228 Passed, 107 Skipped, 40.69s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We need to support federation search, according to if MLS is enabled, or if it is configured or not in the backend.
Solutions
Create a new use case centralizing the logic to decide if we need to support federation or not for this: team/conversation/backend.
Before the logic was in the view model in AR, but here is centralized and we can test all the cases for it, therefore now the view model just calls this use case to decide if we need to enable cross domain search.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.