-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bulletproofing crypto box to cc migration (WPB-14250) (🍒4.6) #3136
Merged
yamilmedina
merged 10 commits into
release/android-cycle-4.6
from
chore/bulletproofing-cbox-ccmigration-zulu
Nov 28, 2024
Merged
chore: bulletproofing crypto box to cc migration (WPB-14250) (🍒4.6) #3136
yamilmedina
merged 10 commits into
release/android-cycle-4.6
from
chore/bulletproofing-cbox-ccmigration-zulu
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes/initiative: federation-wire-cloud
Activate Federation with MLS on Wire Cloud
label
Nov 27, 2024
MohamadJaara
approved these changes
Nov 27, 2024
Merged
8 tasks
Datadog ReportAll test runs ❌ 2 Total Test Services: 1 Failed, 1 Passed Test Services
❌ Failed Tests (1)
|
Quality Gate passedIssues Measures |
saleniuk
approved these changes
Nov 28, 2024
m-zagorski
approved these changes
Nov 28, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT CHERRY PICK
echoes/initiative: federation-wire-cloud
Activate Federation with MLS on Wire Cloud
🚨 Potential breaking changes
👕 size: L
type: chore 🧹
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When enabling core crypto storage, if there are any Proteus clients, we need to migrate them from CryptoBox.
Things usually don't go as planned, so we need to have a recovery plan in place.
Causes (Optional)
There might be some errors while migrating.
Solutions
Implement a recovery plan for this case:
LogoutReason
, so we can act (cleanup) accordinglyIf everything goes smoothly, the user will be prompted to login again, preserving their local history.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
Notes (Optional)
Note
This approach seems "more correct", since if we try to create a new device only -as the ticket suggested- we will run into the issue of the refresh token not being valid anymore, since it was associated with the broken client that we were trying to migrate. And we can't associate the previous refresh token with a different client, we get a 403.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.