Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore: update sqlcipher [WPB-11808] (#3069)" 🍒 #3138

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 28, 2024

BugWPB-11808 [Android] app stalls when fetching a page of conversations from the local DB

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This reverts commit 96044bc.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

4.6.1 is causing performance issues

Solutions

revert to 4.5.7

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. Fix PR Title 🤦‍♂️ 👕 size: XS labels Nov 28, 2024
@MohamadJaara MohamadJaara added echoes: unplanned/quick-win Work items completed to address issues quickly, without extensive planning. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Nov 28, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 29, 2024
Copy link
Contributor Author

github-actions bot commented Nov 29, 2024

Test Results

3 335 tests  ±0   3 228 ✅ ±0   5m 12s ⏱️ -4s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 81f2661. ± Comparison against base commit 4c476f7.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.18%. Comparing base (4c476f7) to head (81f2661).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3138      +/-   ##
===========================================
+ Coverage    54.17%   54.18%   +0.01%     
===========================================
  Files         1251     1251              
  Lines        36408    36408              
  Branches      3681     3681              
===========================================
+ Hits         19724    19728       +4     
+ Misses       15263    15260       -3     
+ Partials      1421     1420       -1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c476f7...81f2661. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: revert/bump-sqlcipher-cherry-pick
Commit report: 7f2b1f5
Test service: kalium-jvm

✅ 0 Failed, 3228 Passed, 107 Skipped, 37.94s Total Time

Merged via the queue into develop with commit b391c81 Nov 29, 2024
20 of 22 checks passed
@MohamadJaara MohamadJaara deleted the revert/bump-sqlcipher-cherry-pick branch November 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned/quick-win Work items completed to address issues quickly, without extensive planning. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. Fix PR Title 🤦‍♂️ 👕 size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants