Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Call sharing metadata [WPB-14605] #3142

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Dec 3, 2024

TaskWPB-14605 [Android] Count share screen duration for end call segmentation

https://wearezeta.atlassian.net/browse/WPB-14605

What's new in this PR?

Issues

For analytic purposes we need to gather screen sharing metadata:

  • Total time screenshare was on during a call (local to phone, we dont have the ability to know after joining a call for how long the sharing was previously on)
  • Total number of unique people that shared the screen

Solutions

Call metadata have additional object CallSharingScreenMetadata which stores all of the data.
On each participant update we also update the sharing screen metadata


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

3 339 tests  +5   3 232 ✅ +5   5m 4s ⏱️ +22s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 4f8716c. ± Comparison against base commit 346034a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

🐰 Bencher Report

Branchfeat/call-sharing-metadata
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
656,288.34
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
322,927,668.50
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,326,400,186.59
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,484,216.01
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.19%. Comparing base (ee39af7) to head (4f8716c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...wire/kalium/logic/data/call/CallMetadataProfile.kt 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3142   +/-   ##
========================================
  Coverage    54.18%   54.19%           
========================================
  Files         1251     1251           
  Lines        36403    36429   +26     
  Branches      3680     3682    +2     
========================================
+ Hits         19725    19742   +17     
- Misses       15259    15268    +9     
  Partials      1419     1419           
Files with missing lines Coverage Δ
.../com/wire/kalium/logic/data/call/CallRepository.kt 87.72% <100.00%> (+0.66%) ⬆️
...wire/kalium/logic/data/call/CallMetadataProfile.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee39af7...4f8716c. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/call-sharing-metadata
Commit report: e95230a
Test service: kalium-jvm

✅ 0 Failed, 3232 Passed, 107 Skipped, 38.28s Total Time

@m-zagorski m-zagorski changed the title feat: All sharing metadata [WPB-14605] feat: Call sharing metadata [WPB-14605] Dec 3, 2024
@m-zagorski m-zagorski added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 06c284a Dec 4, 2024
27 checks passed
@m-zagorski m-zagorski deleted the feat/call-sharing-metadata branch December 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants