Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update federation flag when fetching server config [WPB-14728] 🍒 #3144

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2024

BugWPB-14728 [Android] Make sure clients fetch all configurations regularly

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

federation flag was not updated when updating api version

Solutions

update it

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... type: bug / fix 🐞 👕 size: M 🚨 Potential breaking changes labels Dec 3, 2024
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs some merge conflicts resolution for it, before merge

@MohamadJaara MohamadJaara requested a review from saleniuk December 6, 2024 13:23
Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link
Contributor Author

github-actions bot commented Dec 6, 2024

Test Results

3 339 tests  +5   3 232 ✅ +5   5m 32s ⏱️ +50s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 6d27510. ± Comparison against base commit 346034a.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

github-actions bot commented Dec 6, 2024

@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.19%. Comparing base (346034a) to head (6d27510).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...gic/configuration/server/ServerConfigRepository.kt 30.76% 9 Missing ⚠️
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3144      +/-   ##
===========================================
+ Coverage    54.17%   54.19%   +0.01%     
===========================================
  Files         1251     1251              
  Lines        36403    36458      +55     
  Branches      3680     3689       +9     
===========================================
+ Hits         19723    19758      +35     
- Misses       15261    15277      +16     
- Partials      1419     1423       +4     
Files with missing lines Coverage Δ
...nfiguration/server/CustomServerConfigRepository.kt 81.48% <100.00%> (+1.08%) ⬆️
...m/logic/feature/server/UpdateApiVersionsUseCase.kt 83.87% <100.00%> (ø)
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 58.53% <66.66%> (-0.48%) ⬇️
...gic/configuration/server/ServerConfigRepository.kt 64.38% <30.76%> (-5.46%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346034a...6d27510. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/update-federation-flag-when-fetching-server-config-cherry-pick
Commit report: eb75a24
Test service: kalium-jvm

✅ 0 Failed, 3232 Passed, 107 Skipped, 1m 7.24s Total Time

Merged via the queue into develop with commit 212ddce Dec 6, 2024
23 checks passed
@MohamadJaara MohamadJaara deleted the fix/update-federation-flag-when-fetching-server-config-cherry-pick branch December 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud echoes: unplanned/incident Work items addressing critical product defects that require immediate action, such as bugs, platf... 🚨 Potential breaking changes 👕 size: M type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants