Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API v7 changes #WPB-14798 #3145

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 4, 2024

TaskWPB-14798 [Android] API v7 implement last changes

What's new in this PR?

Updated API v7 according a change log

Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test Results

3 339 tests  ±0   3 232 ✅ ±0   5m 32s ⏱️ +39s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit ff09fac. ± Comparison against base commit 06c284a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

🐰 Bencher Report

Branchfeat/api_v7_changes
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
666,018.84
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
404,598,411.55
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,317,334,977.85
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,727,218.68
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.18%. Comparing base (06c284a) to head (ff09fac).

Files with missing lines Patch % Lines
.../network/api/v7/authenticated/ConversationApiV7.kt 0.00% 8 Missing ⚠️
.../network/api/v0/authenticated/ConversationApiV0.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3145      +/-   ##
===========================================
- Coverage    54.19%   54.18%   -0.02%     
===========================================
  Files         1251     1251              
  Lines        36429    36437       +8     
  Branches      3682     3682              
===========================================
- Hits         19743    19742       -1     
- Misses       15267    15276       +9     
  Partials      1419     1419              
Files with missing lines Coverage Δ
.../network/api/v0/authenticated/ConversationApiV0.kt 60.33% <0.00%> (ø)
.../network/api/v7/authenticated/ConversationApiV7.kt 50.00% <0.00%> (-40.00%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c284a...ff09fac. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/api_v7_changes
Commit report: 986639d
Test service: kalium-jvm

✅ 0 Failed, 3232 Passed, 107 Skipped, 44.5s Total Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit 645b7db Dec 6, 2024
24 checks passed
@MohamadJaara MohamadJaara deleted the feat/api_v7_changes branch December 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants