Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user folders [WPB-14442] #3147

Merged
merged 7 commits into from
Dec 10, 2024
Merged

feat: user folders [WPB-14442] #3147

merged 7 commits into from
Dec 10, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 6, 2024

TaskWPB-14442 [Android] - Conversation Folders - filter conversation list by folder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added user folders to fetch all folders without favorites
  • changed ConversationFilter from enum to sealed class to have folderId and folderName in ConversationFilter.Folder

@Garzas Garzas self-assigned this Dec 6, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

3 340 tests  ±0   3 233 ✅ ±0   5m 45s ⏱️ -12s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 8bf7a23. ± Comparison against base commit 46ab0bc.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 6, 2024

Datadog Report

Branch report: feat/user-folders
Commit report: aebf559
Test service: kalium-jvm

✅ 0 Failed, 3233 Passed, 107 Skipped, 1m 8.01s Total Time

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🐰 Bencher Report

Branchfeat/user-folders
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
668,454.97
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
351,622,291.23
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,307,829,327.49
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,258,782.35
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 10.14493% with 62 lines in your changes missing coverage. Please review.

Project coverage is 54.15%. Comparing base (46ab0bc) to head (8bf7a23).

Files with missing lines Patch % Lines
...rveConversationListDetailsWithEventsUseCaseImpl.kt 0.00% 13 Missing ⚠️
...lium/logic/data/conversation/ConversationFilter.kt 0.00% 11 Missing ⚠️
...o/conversation/folder/ConversationFolderDAOImpl.kt 9.09% 10 Missing ⚠️
...lium/logic/data/conversation/ConversationMapper.kt 0.00% 8 Missing and 1 partial ⚠️
...e/conversation/folder/ObserveUserFoldersUseCase.kt 0.00% 8 Missing ⚠️
...nversation/folders/ConversationFolderRepository.kt 0.00% 4 Missing and 1 partial ⚠️
...lium/logic/data/conversation/ConversationFolder.kt 0.00% 4 Missing ⚠️
.../logic/data/conversation/ConversationRepository.kt 50.00% 1 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3147      +/-   ##
===========================================
- Coverage    54.20%   54.15%   -0.06%     
===========================================
  Files         1249     1250       +1     
  Lines        36449    36494      +45     
  Branches      3688     3697       +9     
===========================================
+ Hits         19757    19762       +5     
- Misses       15269    15308      +39     
- Partials      1423     1424       +1     
Files with missing lines Coverage Δ
...a/conversation/ConversationRepositoryExtensions.kt 86.95% <100.00%> (ø)
...on/folder/ObserveConversationsFromFolderUseCase.kt 100.00% <100.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt 62.37% <50.00%> (ø)
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...lium/logic/data/conversation/ConversationFolder.kt 0.00% <0.00%> (ø)
...nversation/folders/ConversationFolderRepository.kt 86.56% <0.00%> (-7.09%) ⬇️
...e/conversation/folder/ObserveUserFoldersUseCase.kt 0.00% <0.00%> (ø)
...lium/logic/data/conversation/ConversationMapper.kt 58.02% <0.00%> (-0.13%) ⬇️
...o/conversation/folder/ConversationFolderDAOImpl.kt 75.00% <9.09%> (-13.89%) ⬇️
...lium/logic/data/conversation/ConversationFilter.kt 0.00% <0.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ab0bc...8bf7a23. Read the comment docs.

@Garzas Garzas enabled auto-merge December 10, 2024 10:00
@Garzas Garzas added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit 26b7d4b Dec 10, 2024
23 checks passed
@Garzas Garzas deleted the feat/user-folders branch December 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants