Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set api v7 as supported [WPB-14866] #3152

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Dec 6, 2024

StoryWPB-14866 [Android] mark api v7 as supported


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

set api v7 as supported

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

3 340 tests  ±0   3 233 ✅ ±0   5m 55s ⏱️ +15s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit db2d181. ± Comparison against base commit d8b69f1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

@MohamadJaara MohamadJaara changed the title feat: set api v7 as supported feat: set api v7 as supported [14866] Dec 6, 2024
@vitorhugods vitorhugods changed the title feat: set api v7 as supported [14866] feat: set api v7 as supported [WPB-14866] Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 6, 2024

Datadog Report

Branch report: feat/set-api-v7-as-supported
Commit report: 62665b6
Test service: kalium-jvm

✅ 0 Failed, 3233 Passed, 107 Skipped, 1m 9.29s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.20%. Comparing base (d8b69f1) to head (db2d181).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3152   +/-   ##
========================================
  Coverage    54.20%   54.20%           
========================================
  Files         1249     1249           
  Lines        36449    36449           
  Branches      3688     3688           
========================================
  Hits         19757    19757           
  Misses       15269    15269           
  Partials      1423     1423           
Files with missing lines Coverage Δ
...lin/com/wire/kalium/network/BackendMetaDataUtil.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b69f1...db2d181. Read the comment docs.

@yamilmedina yamilmedina added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit 46ab0bc Dec 6, 2024
23 checks passed
@yamilmedina yamilmedina deleted the feat/set-api-v7-as-supported branch December 6, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants