-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backup): visibility modifier [WPB-10575] #3153
refactor(backup): visibility modifier [WPB-10575] #3153
Conversation
Quality Gate passedIssues Measures |
Test Results3 313 tests 3 206 ✅ 5m 17s ⏱️ Results for commit 7b682b5. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic/multiplatform-backup #3153 +/- ##
============================================================
Coverage ? 54.03%
============================================================
Files ? 1246
Lines ? 36152
Branches ? 3656
============================================================
Hits ? 19534
Misses ? 15207
Partials ? 1411 Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3206 Passed, 107 Skipped, 41.33s Total Time |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
As a library that will be consumed by other clients, we should be very careful to not expose unnecessary internals to consumers.
Solutions
Make visibility modifiers mandatory, so that we do not have accidental
public
entities.Testing
N/A
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.