Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backup): visibility modifier [WPB-10575] #3153

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Dec 7, 2024

StoryWPB-10575 Cross Platform Backup: Write common backup / restore library


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As a library that will be consumed by other clients, we should be very careful to not expose unnecessary internals to consumers.

Solutions

Make visibility modifiers mandatory, so that we do not have accidental public entities.

Testing

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Dec 7, 2024
Copy link

sonarqubecloud bot commented Dec 7, 2024

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Test Results

3 313 tests   3 206 ✅  5m 17s ⏱️
  566 suites    107 💤
  566 files        0 ❌

Results for commit 7b682b5.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic/multiplatform-backup@f16d679). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             epic/multiplatform-backup    #3153   +/-   ##
============================================================
  Coverage                             ?   54.03%           
============================================================
  Files                                ?     1246           
  Lines                                ?    36152           
  Branches                             ?     3656           
============================================================
  Hits                                 ?    19534           
  Misses                               ?    15207           
  Partials                             ?     1411           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16d679...7b682b5. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: backup/refactor/visibility-modifier
Commit report: eabd3ac
Test service: kalium-jvm

✅ 0 Failed, 3206 Passed, 107 Skipped, 41.33s Total Time

@vitorhugods vitorhugods merged commit 3a7656d into epic/multiplatform-backup Dec 9, 2024
22 checks passed
@vitorhugods vitorhugods deleted the backup/refactor/visibility-modifier branch December 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: M type: refactoring 🛠
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants