Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable folders update handler [WPB-14923] #3161

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 10, 2024

TaskWPB-14923 [Android] Disable favorites and folders for 4.10


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • disabled folders update handler for 4.10 release

@Garzas Garzas self-assigned this Dec 10, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Test Results

3 339 tests   - 1   3 232 ✅  - 1   5m 46s ⏱️ -11s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit bbd16fe. ± Comparison against base commit 46ab0bc.

This pull request removes 1 test.
com.wire.kalium.logic.sync.receiver.UserPropertiesEventReceiverTest ‑ givenFoldersUpdateEvent_repositoryIsInvoked[jvm]

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.15%. Comparing base (46ab0bc) to head (bbd16fe).

Files with missing lines Patch % Lines
...logic/sync/receiver/UserPropertiesEventReceiver.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3161      +/-   ##
=====================================================
- Coverage              54.20%   54.15%   -0.06%     
=====================================================
  Files                   1249     1249              
  Lines                  36449    36448       -1     
  Branches                3688     3688              
=====================================================
- Hits                   19757    19738      -19     
- Misses                 15269    15287      +18     
  Partials                1423     1423              
Files with missing lines Coverage Δ
...logic/sync/receiver/UserPropertiesEventReceiver.kt 38.46% <0.00%> (-35.62%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ab0bc...bbd16fe. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/disable-folder-labels-handler
Commit report: cc97796
Test service: kalium-jvm

✅ 0 Failed, 3232 Passed, 107 Skipped, 1m 9.73s Total Time

@Garzas Garzas added this pull request to the merge queue Dec 10, 2024
Merged via the queue into release/candidate with commit 5b8fd62 Dec 10, 2024
21 checks passed
@Garzas Garzas deleted the chore/disable-folder-labels-handler branch December 10, 2024 16:03
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT CHERRY PICK echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants