fix: Login to second device does not have MLS capabilities #WPB-14906

[borichellow]

WPB-14906 [Android] Login to second device does not have MLS capabilities

What's new in this PR?

Issues

When a user logs in to a second device after logging in to an MLS capable client, he does not have MLS capabilities on the second device: no previously created conversations and not MLS thumbprints in device details.

Causes (Optional)

field creator in ConversationResponseDTOV3 suppose to be nullable.
Looks like we just forgot to add "?" to the field.
So when backend sends conversations with creator = null parser on android side fails.

Solutions

Make creator filed nullable. Later ConversationResponseDTOV3 mapped into ConversationResponse which has val creator: String?, so it should not add any problems :)

[github-actions]

Test Results

3 340 tests  ±0   3 233 ✅ ±0   5m 56s ⏱️ ±0s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit a8e44ab. ± Comparison against base commit 5baff8e.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	fix/login_to_second_device_does_not_have_mls_capabilities
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	657,337.67
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	336,538,914.16
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,311,261,624.40
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,623,820.47

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.11%. Comparing base (5baff8e) to head (a8e44ab).

Files with missing lines	Patch %	Lines
...authenticated/conversation/ConversationResponse.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3164   +/-   ##
========================================
  Coverage    54.11%   54.11%           
========================================
  Files         1252     1252           
  Lines        36519    36519           
  Branches      3699     3699           
========================================
  Hits         19761    19761           
  Misses       15333    15333           
  Partials      1425     1425           

Files with missing lines	Coverage Δ
...authenticated/conversation/ConversationResponse.kt	0.00% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5baff8e...a8e44ab. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/login_to_second_device_does_not_have_mls_capabilities
Commit report: 5068178
Test service: kalium-jvm

✅ 0 Failed, 3233 Passed, 107 Skipped, 1m 10.82s Total Time

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud