fix: Login to second device does not have MLS capabilities RC #WPB-14906

[borichellow]

WPB-14906 [Android] Login to second device does not have MLS capabilities

What's new in this PR?

Issues

When a user logs in to a second device after logging in to an MLS capable client, he does not have MLS capabilities on the second device: no previously created conversations and not MLS thumbprints in device details.

Causes (Optional)

field creator in ConversationResponseDTOV3 suppose to be nullable.
Looks like we just forgot to add "?" to the field.
So when backend sends conversations with creator = null parser on android side fails.

Solutions

Make creator filed nullable. Later ConversationResponseDTOV3 mapped into ConversationResponse which has val creator: String?, so it should not add any problems :)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 339 tests  ±0   3 232 ✅ ±0   5m 51s ⏱️ -1s
  572 suites ±0     107 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 378907b. ± Comparison against base commit 5b8fd62.

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.15%. Comparing base (5b8fd62) to head (378907b).

Files with missing lines	Patch %	Lines
...authenticated/conversation/ConversationResponse.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           release/candidate    #3165      +/-   ##
=====================================================
+ Coverage              54.14%   54.15%   +0.01%     
=====================================================
  Files                   1249     1249              
  Lines                  36448    36448              
  Branches                3688     3688              
=====================================================
+ Hits                   19736    19740       +4     
+ Misses                 15288    15285       -3     
+ Partials                1424     1423       -1     

Files with missing lines	Coverage Δ
...authenticated/conversation/ConversationResponse.kt	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8fd62...378907b. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/login_to_second_device_does_not_have_mls_capabilities_rc
Commit report: 1c4bc13
Test service: kalium-jvm

✅ 0 Failed, 3232 Passed, 107 Skipped, 1m 10.65s Total Time